Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Google proxy-mirror-cache for docker hub to CI tests #6957

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

LuckySB
Copy link
Contributor

@LuckySB LuckySB commented Nov 26, 2020

/kind failing-test

What this PR does / why we need it:

CI test failed due docker hub pull limit.
add Google registry proxy-mirror

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LuckySB

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2020
@LuckySB
Copy link
Contributor Author

LuckySB commented Nov 27, 2020

Public Google doesn't work as expected

Images missing in the mirror are not pumped out, but an error is returned

Nov 27 11:40:37 dev-kube-jump dockerd: time="2020-11-27T11:40:37.123495051+03:00" level=debug msg="Trying to pull nginx from https://mirror.gcr.io/ v2"
Nov 27 11:40:37 dev-kube-jump dockerd: time="2020-11-27T11:40:37.651488312+03:00" level=info msg="Attempting next endpoint for pull after error: manifest unkn
own: Failed to fetch \"1.18\" from request \"/v2/library/nginx/manifests/1.18\"."
Nov 27 11:40:37 dev-kube-jump dockerd: time="2020-11-27T11:40:37.651558174+03:00" level=debug msg="Trying to pull nginx from https://registry-1.docker.io v2"

Need second own docker registry mirror, runned on CI servers
@Miouge1 Please see #6959

@floryut
Copy link
Member

floryut commented Nov 27, 2020

Ok so do we still need this PR ? We've removed most dockerhub images and if the remaining aren't in mirror.gcr.io then there is no real use, isn't it ?

@LuckySB
Copy link
Contributor Author

LuckySB commented Nov 27, 2020

yes. this PR is need.
Also need add support registry mirror to containerd and crio CRI.

docker hub images:
grep docker_image_repo roles/download/defaults/main.yml
I don't understand how they can be removed

@LuckySB
Copy link
Contributor Author

LuckySB commented Nov 27, 2020

and now mirror.gcr.io has an image nginx:1.19, on the pull of which CI tasks broke yesterday

So mirror.gcr.io add images asynchronously

@floryut
Copy link
Member

floryut commented Nov 27, 2020

and now mirror.gcr.io has an image nginx:1.19, on the pull of which CI tasks broke yesterday

So mirror.gcr.io add images asynchronously

Ok that's good then ! Thanks @LuckySB
And yes what I meant is that we removed a lot of dockerhub references, but for some (weave, dashboard etc..) dockerhub is the only source so mirroring/private rep is the only choice

@floryut
Copy link
Member

floryut commented Nov 27, 2020

Let's merge this then!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit d739a6b into kubernetes-sigs:master Nov 27, 2020
@floryut floryut mentioned this pull request Jan 8, 2021
LuckySB added a commit to southbridgeio/kubespray that referenced this pull request Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants