-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dual stack IPv4 & IPv6 networking #6859
Support dual stack IPv4 & IPv6 networking #6859
Conversation
Hi @miff2000. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@miff2000: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@holmsten, would you be able to take a look this PR please? |
/ok-to-test |
roles/kubernetes/master/templates/kubeadm-config.v1beta2.yaml.j2
Outdated
Show resolved
Hide resolved
roles/kubernetes/master/templates/kubeadm-config.v1beta2.yaml.j2
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a side note, to use dual stack networking, you need to have this set:
kube_feature_gates:
- IPv6DualStack=true
Do you think I should just add a node into the documentation, or try and set them automatically for the user, working with the #6851 changes?
roles/kubernetes/master/templates/kubeadm-config.v1beta2.yaml.j2
Outdated
Show resolved
Hide resolved
roles/kubernetes/master/templates/kubeadm-config.v1beta2.yaml.j2
Outdated
Show resolved
Hide resolved
roles/kubernetes/master/templates/kubeadm-config.v1beta2.yaml.j2
Outdated
Show resolved
Hide resolved
Do we want to set |
Sure! I didn't know that was a thing, but would usually prefer a rebase too. Can I do that myself? |
Yes |
/label tide/merge-method-rebase |
@miff2000: The
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
When enable_dual_stack_networks is set, we need to make sure IPv6DualStack=true is set too, otherwise we end up with a broken cluster.
/lgtm |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Really good work @miff2000 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, miff2000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
This adds functionality to Kubespray to support dual stack deployments (IPv4 & IPv6 combined)
Which issue(s) this PR fixes:
Fixes #6791
Special notes for your reviewer:
Does this PR introduce a user-facing change?: