-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set feature gates in kube-proxy ConfigMap #6851
Set feature gates in kube-proxy ConfigMap #6851
Conversation
Command line flags aren't added to kube-proxy which results in missing feature gates set in this component. Add appropriate setting to ConfigMap instead. Signed-off-by: Maciej Wereski <[email protected]>
Welcome @maciejaszek! |
Hi @maciejaszek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, maciejaszek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Command line flags aren't added to kube-proxy which results in missing feature gates set in this component. Add appropriate setting to ConfigMap instead. Signed-off-by: Maciej Wereski <[email protected]>
Command line flags aren't added to kube-proxy which results in missing
feature gates set in this component. Add appropriate setting to
ConfigMap instead.
Signed-off-by: Maciej Wereski [email protected]
What type of PR is this?
What this PR does / why we need it:
It adds feature gates to kube-proxy. Some features (like ServiceTopology) won't work properly without these settings in kube-proxy.
Which issue(s) this PR fixes:
Fixes #6850
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No