Fix flakey test + cleanup in testcases/030-checknetwork #11792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
This is a followup to 2ba28a3 (Revert "Wait for available API token in a new namespace (kubernetes-sigs#7045)", 2024-10-25). While checking for the serviceaccount token is not effective, there is still a race when creating a Pod directly, because the ServiceAccount itself might not be created yet. More details at kubernetes/kubernetes#66689. This cause very frequent flakes in our CI with spurious failures. Use a Deployment instead ; it will takes cares of creating the Pods and retrying ; it also let us use kubectl rollout status instead of manually checking for the pods.
There is no pods with hostNetwork deployed in this test, and therefore the tasks are skipped / empty output (checked in CI).
VannTen
force-pushed
the
flake/race_sa_creation
branch
from
3889889 to
12ed1fc
Compare
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
yankay
reviewed
Dec 16, 2024
| runAsUser: 1000 | ||
| runAsNonRoot: true | ||
| seccompProfile: | ||
| type: RuntimeDefault |
There was a problem hiding this comment.
HI @VannTen
If there is podAntiAffinity to assign the pod between nodes, it can help to test the network connection between nodes.
Is it a good idea?
There was a problem hiding this comment.
Why not, but I would put that in another PR.
Here I'm just switching to Deployment to avoid (well, rather, make it the controller problem ^^) the race with de sa cration.
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
Follow-up to #11667
Basically, creating a pod just afer its namespace is racey (see Creating a pod fails if default service account does not exist with the default service account enabled. kubernetes/kubernetes#66689)
Instead we create a deployment.
Cleanup of noop tasks in 030-checknetwork (no idea why we're checking for hostNetwork pods here when we don't have any, see commit message for full details)
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
/label tide/merge-method-merge