Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the failed CI test of docker-machine #11062

Closed

Conversation

yankay
Copy link
Member

@yankay yankay commented Apr 8, 2024

What type of PR is this?

/kind flake

What this PR does / why we need it:

Skip the failed CI test of the docker-machine to Prevent the PR from breaking.

The CI failed because of #11049 .

It needs a lot of time to refactor. So, skip it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Skip the failed CI test of docker-machine

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2024
@yankay yankay force-pushed the skip-docker-machine-test branch 3 times, most recently from 05f9dbb to 423fa08 Compare April 8, 2024 12:10
@yankay yankay force-pushed the skip-docker-machine-test branch from 423fa08 to 7ce29f3 Compare April 8, 2024 12:11
@yankay yankay requested a review from mzaian April 8, 2024 12:43
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yankay

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VannTen
Copy link
Contributor

VannTen commented Apr 8, 2024

I don't think we should just skip theses CI runs. Unlike #10886 which we're for optional features, this tests basic operations. If we just remove those, we risk to merge regressions (this already happens a lot).
Can we discuss this a bit more ?
/hold
(temporarily).

FYI, molecule can be used with kubevirt, apparently : https://github.com/ansible-community/molecule-kubevirt
There is also a vagrant plugin for kubevirt, which would let us indirectly use kubevirt in molecule (since AFAIK it currently use vagrant)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2024
@yankay
Copy link
Member Author

yankay commented Apr 9, 2024

I don't think we should just skip theses CI runs. Unlike #10886 which we're for optional features, this tests basic operations. If we just remove those, we risk to merge regressions (this already happens a lot). Can we discuss this a bit more ? /hold (temporarily).

FYI, molecule can be used with kubevirt, apparently : https://github.com/ansible-community/molecule-kubevirt There is also a vagrant plugin for kubevirt, which would let us indirectly use kubevirt in molecule (since AFAIK it currently use vagrant)

Thanks @VannTen

I'm working on it #11063.
If lucky, the PR will be complete in a while. Or it may take time and help :-)

And from https://ansible.readthedocs.io/projects/team-devtools/stats/molecule-plugins/ .
"
Unmaintained drivers archived between January 5th-8th, 2023: openstack, goss, libvirt, alicloud, vmware, digitalocean, kubevirt, lxd, inspec.
"

@yankay
Copy link
Member Author

yankay commented Apr 9, 2024

The CI has been repaired by :

  1. Upgrade to the docker-machine-driver-meta:
    https://github.com/equinix/docker-machine-driver-metal/releases/tag/v0.6.0

  2. Change the config of Gitlab to using metro :

root@docker-machine-runner:/etc/gitlab-runner# diff config.toml config.toml-backup
45,47c45,46
< #      "metal-facility-code=pa4",
<       "metal-metro-code=am",
<       "metal-termination-time=4hours",
---
>       "metal-facility-code=am6",
>       "metal-ttl=4h",

@yankay yankay closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants