-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip the failed CI test of docker-machine #11062
Conversation
05f9dbb
to
423fa08
Compare
423fa08
to
7ce29f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yankay
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't think we should just skip theses CI runs. Unlike #10886 which we're for optional features, this tests basic operations. If we just remove those, we risk to merge regressions (this already happens a lot). FYI, molecule can be used with kubevirt, apparently : https://github.com/ansible-community/molecule-kubevirt |
Thanks @VannTen I'm working on it #11063. And from https://ansible.readthedocs.io/projects/team-devtools/stats/molecule-plugins/ . |
The CI has been repaired by :
|
What type of PR is this?
What this PR does / why we need it:
Skip the failed CI test of the docker-machine to Prevent the PR from breaking.
The CI failed because of #11049 .
It needs a lot of time to refactor. So, skip it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: