-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move perma failing jobs in CI to manual run #10886
Move perma failing jobs in CI to manual run #10886
Conversation
A little afraid that moving them to manual will end up never trying to fix them and only ending up basically removing them |
Well it's not like we're fixing them now, AFAICT those tests are broken for quite some time ; perma-failing is effectively just noise. |
Just checked the run times of theses jobs (one sample) : 16, 19, 10, 6 ,4 (minutes) |
AFAICT,
Well, there is no reason too. They don't cause any problem as 'manual', and we can switch them to mandatory (no failure allowed) in the PR which fix the underlying problem |
Can we maybe add a note in the code to flag them as failing ? that would ease my mind about putting them as manual 😅 |
Yeah I'll add FIXME comments
|
4d88561
to
2d97315
Compare
Should free CI resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VannTen fine by me, thank you
Only missing a lgtm then
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here it is! :D
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Should free CI resources
Should free CI resources
What type of PR is this?
/kind flake
What this PR does / why we need it:
Some our CI jobs are perma-failing and "allowed to fail".
Thus they takes up CI resources while not guarding anything.
Move them to manual instead, which should free some CI resources.
If/when we fix the underlying use case, we should re-enable those tests.
Does this PR introduce a user-facing change?: