Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move perma failing jobs in CI to manual run #10886

Merged

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Feb 5, 2024

What type of PR is this?
/kind flake

What this PR does / why we need it:
Some our CI jobs are perma-failing and "allowed to fail".
Thus they takes up CI resources while not guarding anything.
Move them to manual instead, which should free some CI resources.

If/when we fix the underlying use case, we should re-enable those tests.

Does this PR introduce a user-facing change?:

Move perma failing jobs in CI to manual run

@k8s-ci-robot k8s-ci-robot added the kind/flake Categorizes issue or PR as related to a flaky test. label Feb 5, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 5, 2024
@floryut
Copy link
Member

floryut commented Feb 5, 2024

A little afraid that moving them to manual will end up never trying to fix them and only ending up basically removing them

@VannTen
Copy link
Contributor Author

VannTen commented Feb 5, 2024

A little afraid that moving them to manual will end up never trying to fix them and only ending up basically removing them

Well it's not like we're fixing them now, AFAICT those tests are broken for quite some time ; perma-failing is effectively just noise.

@VannTen
Copy link
Contributor Author

VannTen commented Feb 12, 2024

Just checked the run times of theses jobs (one sample) : 16, 19, 10, 6 ,4 (minutes)
Since they're retried one time, that's 110 minutes of Ci we're using for each pull request, when we know already that they're failing.
I think a TODO or FIXME somewhere would be just as effective (or an open issue in Github). Don't you @floryut @mzaian ?

@VannTen
Copy link
Contributor Author

VannTen commented Feb 12, 2024

AFAICT,

  • vagrant_ubuntu20-calico-dual-stack fails since at least 7 months (and 18 was failing before that)
  • molecule_kata fails since 8 months
  • molecule_{gvisor,youki} since 6 months
  • vagrant_fedora37-kube-router since 6 months as well
    So it's not like it has created motivation (or more time out of thin air) to fix them ^.

A little afraid that moving them to manual will end up never trying to fix them and only ending up basically removing them

Well, there is no reason too. They don't cause any problem as 'manual', and we can switch them to mandatory (no failure allowed) in the PR which fix the underlying problem

@floryut
Copy link
Member

floryut commented Feb 19, 2024

Can we maybe add a note in the code to flag them as failing ? that would ease my mind about putting them as manual 😅

@VannTen
Copy link
Contributor Author

VannTen commented Feb 19, 2024 via email

@VannTen VannTen force-pushed the flake/perma_failing_jobs_manual branch from 4d88561 to 2d97315 Compare February 19, 2024 15:38
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VannTen fine by me, thank you

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@VannTen
Copy link
Contributor Author

VannTen commented Feb 19, 2024 via email

Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here it is! :D
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, MrFreezeex, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 12c8d04 into kubernetes-sigs:master Feb 19, 2024
60 checks passed
@mzaian mzaian mentioned this pull request Apr 26, 2024
dibi-codes pushed a commit to fino-digital/kubespray that referenced this pull request May 7, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants