-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge stops and removes systemd services tasks in reset playbook #10902
Merge stops and removes systemd services tasks in reset playbook #10902
Conversation
Hi @kimsehwan96. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kimsehwan96 Cheers 🙇
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, kimsehwan96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What type of PR is this?
/kind design
What this PR does / why we need it:
This PR merges tasks stop and remove systemd services related with etcd (etcd.service, etcd-events.service).
There is no systemd daemon-reload tasks after stop and remove systemd services about etcd, so if you run command
$ systemctl status etcd
on etcd node after all reset tasks are done then output will be shown which indicate etcd systemd is stopped(inactivated).It may feel confusing about the systemd services are really removed or not.
I think it's better apply this changes if there is no specific reason to seperate this tasks.
By the way, There are
crio
,containerd
tags in- name: Reset | remove services
task and I relocated theetcd.service
,etcd-events.service
systemd serviceswith_items
so I'm worried about it may cause some break in some specific reset usecasesWhich issue(s) this PR fixes:
Fixes #10901
Special notes for your reviewer:
Does this PR introduce a user-facing change?: