Merge stop and remove systemd service task inreset/tasks/main.yml

[kimsehwan96]

What would you like to be added

There are stop and remove systemd service tasks in reset/tasks/main.yml (

kubespray/roles/reset/tasks/main.yml

Lines 2 to 31 in ad565ad

	- name: Reset | stop services
	service:
	name: "{{ item }}"
	state: stopped
	with_items:
	- kubelet.service
	- cri-dockerd.service
	- cri-dockerd.socket
	failed_when: false
	tags:
	- services
	- name: Reset | remove services
	file:
	path: "/etc/systemd/system/{{ item }}"
	state: absent
	with_items:
	- kubelet.service
	- cri-dockerd.service
	- cri-dockerd.socket
	- calico-node.service
	- containerd.service.d/http-proxy.conf
	- crio.service.d/http-proxy.conf
	- k8s-certs-renew.service
	- k8s-certs-renew.timer
	register: services_removed
	tags:
	- services
	- containerd
	- crio

)

By the way, the tasks that stop and remove etcd.service and etcd-events.service are in other tasks (

kubespray/roles/reset/tasks/main.yml

Lines 137 to 157 in ad565ad

	- name: Reset | stop etcd services
	service:
	name: "{{ item }}"
	state: stopped
	with_items:
	- etcd
	- etcd-events
	failed_when: false
	tags:
	- services
	- name: Reset | remove etcd services
	file:
	path: "/etc/systemd/system/{{ item }}.service"
	state: absent
	with_items:
	- etcd
	- etcd-events
	register: services_removed
	tags:
	- services

)

And then, there is no systemd daemon-reload tasks after stop and remove etcd related systemd services, so if you run systemctl status etcd.service then the output shows inactivate etcd related services.

So I think it's better that merging the tasks stop and remove etcd.service, etcd-events.service.

Why is this needed

I think its better that merging the tasks that stop and remove systemd services because if do not, you can get some outputs from $ systemctl status etcd on etcd node after all reset tasks are done. and it may feel confusing about the systemd services are really removed or not.