-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix secondary coredns missing var #10821
Conversation
e592971
to
73fe43c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @VannTen
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@VannTen A near-term patch release for this would be great. The underlying bug breaks cluster DNS during the whole upgrade process. |
You mean including non dual coredns ?
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Unbreak using coredns_dual
Which issue(s) this PR fixes:
Fixes #10816
Special notes for your reviewer:
Does this PR introduce a user-facing change?: