Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix secondary coredns missing var #10821

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Jan 22, 2024

What type of PR is this?
/kind bug

What this PR does / why we need it:
Unbreak using coredns_dual

Which issue(s) this PR fixes:

Fixes #10816

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fix secondary coredns missing var 

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2024
@floryut
Copy link
Member

floryut commented Jan 22, 2024

Duplicate of #10815 let's this if @arusa can fix his CLA

Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @VannTen

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 89d42a7 into kubernetes-sigs:master Jan 22, 2024
65 checks passed
@simon-wessel
Copy link
Contributor

@VannTen A near-term patch release for this would be great. The underlying bug breaks cluster DNS during the whole upgrade process.

@VannTen
Copy link
Contributor Author

VannTen commented Jan 31, 2024 via email

@simon-wessel
Copy link
Contributor

@VannTen This was a wrong assumption on my side, the issue I was talking about is actually #10860

@mzaian mzaian mentioned this pull request Apr 26, 2024
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coredns_dual setup is broken in Kubespray v2.24.0
5 participants