-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing src attribute #10815
Fix missing src attribute #10815
Conversation
Ansible crashed with a syntax error because the src attribute was missing
|
Welcome @arusa! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arusa The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @arusa. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Oh. Sorry, I had not see that PR before doing #10821 which solves the same problem. |
Just saw this also 😆 |
@arusa Are you available otherwise to check CLA ? |
Wow, this was the most complicated contribution I have ever made... for ~15 characters. It's really hard if you just want to send a small bugfix and have to read pages of documentation and jump through burning hoops... I thought multiple times about just letting it be. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
You mean the CNCF CLA, I guess ? Yeah, that's not the most seamless... |
@VannTen: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
With kubespray 2.24.0 ansible crashes with a syntax error while running upgrade-cluster.yml, because the src attribute is missing.
/kind bug