Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing src attribute #10815

Closed
wants to merge 1 commit into from
Closed

Conversation

arusa
Copy link

@arusa arusa commented Jan 19, 2024

With kubespray 2.24.0 ansible crashes with a syntax error while running upgrade-cluster.yml, because the src attribute is missing.

/kind bug

NONE

Ansible crashed with a syntax error because the src attribute was missing
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 19, 2024
Copy link

linux-foundation-easycla bot commented Jan 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: arusa / name: Alexander Rusa (2bfbf78)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 19, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @arusa!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arusa
Once this PR has been reviewed and has the lgtm label, please assign mzaian for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @arusa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from EppO and mzaian January 19, 2024 21:10
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2024
@floryut
Copy link
Member

floryut commented Jan 22, 2024

@arusa Can you please check CLA ?

@VannTen
Copy link
Contributor

VannTen commented Jan 22, 2024

Oh. Sorry, I had not see that PR before doing #10821 which solves the same problem.

@floryut
Copy link
Member

floryut commented Jan 22, 2024

Oh. Sorry, I had not see that PR before doing #10821 which solves the same problem.

Just saw this also 😆

@floryut
Copy link
Member

floryut commented Jan 22, 2024

@arusa Are you available otherwise to check CLA ?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 22, 2024
@arusa
Copy link
Author

arusa commented Jan 22, 2024

Wow, this was the most complicated contribution I have ever made... for ~15 characters. It's really hard if you just want to send a small bugfix and have to read pages of documentation and jump through burning hoops... I thought multiple times about just letting it be.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@VannTen
Copy link
Contributor

VannTen commented Jan 23, 2024

Wow, this was the most complicated contribution I have ever made... for ~15 characters. It's really hard if you just want to send a small bugfix and have to read pages of documentation and jump through burning hoops... I thought multiple times about just letting it be.

You mean the CNCF CLA, I guess ? Yeah, that's not the most seamless...
Let's close this one, since #10821 was merged (and sorry for missing this one before doing mine, again)
/close

@k8s-ci-robot
Copy link
Contributor

@VannTen: Closed this PR.

In response to this:

Wow, this was the most complicated contribution I have ever made... for ~15 characters. It's really hard if you just want to send a small bugfix and have to read pages of documentation and jump through burning hoops... I thought multiple times about just letting it be.

You mean the CNCF CLA, I guess ? Yeah, that's not the most seamless...
Let's close this one, since #10821 was merged (and sorry for missing this one before doing mine, again)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants