Fix image pull fail with insecure-registry #10775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
yankay
force-pushed
the
fix-image-pull-insecure-registry
branch
from
747fb7f to
f3e29fd
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mzaian, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tmurakam
added a commit
to kubespray-offline/kubespray-offline
that referenced
this pull request
Jan 9, 2024
The workaround is not needed because kubespray was fixed with kubernetes-sigs/kubespray#10775
tmurakam
added a commit
to kubespray-offline/kubespray-offline
that referenced
this pull request
Jan 19, 2024
The workaround is not needed because kubespray was fixed with kubernetes-sigs/kubespray#10775
pedro-peter
pushed a commit
to pedro-peter/kubespray
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
After the #10687, the image pulls failed with insecure registry.
Add the config for the insecure registry.
Which issue(s) this PR fixes:
Fixes #10670 (comment)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: