Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ctr pull instead of nerdctl #10687

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

yankay
Copy link
Member

@yankay yankay commented Dec 4, 2023

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

Using ctr pull instead of nerdctl to workaround the #10670 .

Which issue(s) this PR fixes:

Workaround #10670

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Using ctr pull instead of nerdctl to workaround https://github.com/kubernetes-sigs/kubespray/issues/10670.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2023
@VannTen
Copy link
Contributor

VannTen commented Dec 4, 2023

Looks like it works. Log output is pretty messy though, but I guess ctr has some flag to be a tad more quiet ^.

@ant31
Copy link
Contributor

ant31 commented Dec 4, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 4, 2023
@yankay
Copy link
Member Author

yankay commented Dec 5, 2023

Looks like it works. Log output is pretty messy though, but I guess ctr has some flag to be a tad more quiet ^.

Releate to containerd/containerd#9467

@yankay yankay changed the title [WIP] Using ctr pull instead of nerdctl Using ctr pull instead of nerdctl Dec 5, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2023
@floryut
Copy link
Member

floryut commented Dec 5, 2023

@yankay Shouldn't this be changed only for the CI not for the whole codebase ?

@VannTen
Copy link
Contributor

VannTen commented Dec 5, 2023

Well I don't think so. The failure would also happens outisde of CI (or am I mistaken ?) so until nerdctl is fixed... We're a bit stuck with finding a workaround.

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't think so. The failure would also happens outisde of CI (or am I mistaken ?) so until nerdctl is fixed... We're a bit stuck with finding a workaround.

ok fine by me then
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5160e7e into kubernetes-sigs:master Dec 5, 2023
63 checks passed
@yankay yankay mentioned this pull request Dec 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants