-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ctr pull instead of nerdctl #10687
Conversation
1ea281e
to
9561bea
Compare
Looks like it works. Log output is pretty messy though, but I guess ctr has some flag to be a tad more quiet ^. |
/ok-to-test |
Releate to containerd/containerd#9467 |
9561bea
to
fbd0f31
Compare
@yankay Shouldn't this be changed only for the CI not for the whole codebase ? |
Well I don't think so. The failure would also happens outisde of CI (or am I mistaken ?) so until nerdctl is fixed... We're a bit stuck with finding a workaround. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I don't think so. The failure would also happens outisde of CI (or am I mistaken ?) so until nerdctl is fixed... We're a bit stuck with finding a workaround.
ok fine by me then
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Using ctr pull instead of nerdctl to workaround the #10670 .
Which issue(s) this PR fixes:
Workaround #10670
Special notes for your reviewer:
Does this PR introduce a user-facing change?: