-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.23] Fix calico-node in etcd mode #10768
Merged
k8s-ci-robot
merged 3 commits into
kubernetes-sigs:release-2.23
from
VannTen:fix/2.23/calico-etcd
Jan 12, 2024
Merged
[2.23] Fix calico-node in etcd mode #10768
k8s-ci-robot
merged 3 commits into
kubernetes-sigs:release-2.23
from
VannTen:fix/2.23/calico-etcd
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
Categorizes issue or PR as related to a bug.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 4, 2024
VannTen
force-pushed
the
fix/2.23/calico-etcd
branch
4 times, most recently
from
January 8, 2024 09:57
0a32ba7
to
6dc58c5
Compare
…sigs#10725) * Rename aio to all-in-one and document it ADTM. Acronyms don't tell much. * Refactor vm_count in tests provisioning
* Add multinode ci layout * Add test case for calico using etcd datastore
* Calico : add ETCD endpoints to install-cni container * Calico : remove nodename from configmap in etcd mode
VannTen
force-pushed
the
fix/2.23/calico-etcd
branch
from
January 11, 2024 13:23
6dc58c5
to
bcb454d
Compare
/cc @cyclinder |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jan 12, 2024
@VannTen Nice fix /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Backport of #10438 + its test (#10722 and #10725)
Does this PR introduce a user-facing change?: