-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Document the 'all-in-one' layout + small refactoring #10725
CI: Document the 'all-in-one' layout + small refactoring #10725
Conversation
ADTM. Acronyms don't tell much.
0649b65
to
e3a971b
Compare
I'd like to land this to have #10438 include #10722 (so we have a regression testing in CI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@@ -0,0 +1,12 @@ | |||
--- | |||
_vm_count_dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
/assign @cristicalin @floryut |
Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ant31, VannTen, yankay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…sigs#10725) * Rename aio to all-in-one and document it ADTM. Acronyms don't tell much. * Refactor vm_count in tests provisioning
…sigs#10725) * Rename aio to all-in-one and document it ADTM. Acronyms don't tell much. * Refactor vm_count in tests provisioning
* CI: Document the 'all-in-one' layout + small refactoring (#10725) * Rename aio to all-in-one and document it ADTM. Acronyms don't tell much. * Refactor vm_count in tests provisioning * Add test case for calico using etcd datastore (#10722) * Add multinode ci layout * Add test case for calico using etcd datastore * Fix calico-node in etcd mode (#10438) * Calico : add ETCD endpoints to install-cni container * Calico : remove nodename from configmap in etcd mode --------- Co-authored-by: Olivier Levitt <[email protected]>
…sigs#10725) * Rename aio to all-in-one and document it ADTM. Acronyms don't tell much. * Refactor vm_count in tests provisioning
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Rename aio to all-in-one and document it.
ADTM
Acronyms don't tell much.
Also some refactoring in the packet-ci role.
Special notes for your reviewer:
#1665 introduced aio, but without documentation. And apart from digging into the git history (which I just did) it's pretty hard to understand what this means.
Does this PR introduce a user-facing change?: