Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Document the 'all-in-one' layout + small refactoring #10725

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Dec 15, 2023

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Rename aio to all-in-one and document it.

ADTM
Acronyms don't tell much.

Also some refactoring in the packet-ci role.

Special notes for your reviewer:
#1665 introduced aio, but without documentation. And apart from digging into the git history (which I just did) it's pretty hard to understand what this means.

Does this PR introduce a user-facing change?:

CI: Document the 'all-in-one' layout + small refactoring

ADTM.
Acronyms don't tell much.
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2023
@VannTen VannTen force-pushed the ci/document_all_in_one branch from 0649b65 to e3a971b Compare December 15, 2023 12:39
@VannTen
Copy link
Contributor Author

VannTen commented Dec 15, 2023

I'd like to land this to have #10438 include #10722 (so we have a regression testing in CI)
If we could have it done before 1.24 that would be great
/cc @floryut @MrFreezeex @cyclinder

Copy link
Contributor

@ant31 ant31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -0,0 +1,12 @@
---
_vm_count_dict:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2023
@VannTen
Copy link
Contributor Author

VannTen commented Dec 18, 2023

/assign @cristicalin @floryut

@yankay
Copy link
Member

yankay commented Dec 18, 2023

Thanks
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ant31, VannTen, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7395c27 into kubernetes-sigs:master Dec 18, 2023
64 checks passed
VannTen added a commit to VannTen/kubespray that referenced this pull request Jan 4, 2024
…sigs#10725)

* Rename aio to all-in-one and document it

ADTM.
Acronyms don't tell much.

* Refactor vm_count in tests provisioning
VannTen added a commit to VannTen/kubespray that referenced this pull request Jan 11, 2024
…sigs#10725)

* Rename aio to all-in-one and document it

ADTM.
Acronyms don't tell much.

* Refactor vm_count in tests provisioning
k8s-ci-robot pushed a commit that referenced this pull request Jan 12, 2024
* CI: Document the 'all-in-one' layout + small refactoring (#10725)

* Rename aio to all-in-one and document it

ADTM.
Acronyms don't tell much.

* Refactor vm_count in tests provisioning

* Add test case for calico using etcd datastore (#10722)

* Add multinode ci layout

* Add test case for calico using etcd datastore

* Fix calico-node in etcd mode (#10438)

* Calico : add ETCD endpoints to install-cni container

* Calico : remove nodename from configmap in etcd mode

---------

Co-authored-by: Olivier Levitt <[email protected]>
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
…sigs#10725)

* Rename aio to all-in-one and document it

ADTM.
Acronyms don't tell much.

* Refactor vm_count in tests provisioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants