Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dockerfile): python requirements file #10700

Merged

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Dec 7, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:
Ansible update to 2.15 in requires_ansible has broken the usage of kubespray in Dockerfile

Output:

fatal: [localhost]: FAILED! => {
    "assertion": "ansible_version.string is version(minimal_ansible_version, \">=\")",
    "changed": false,
    "evaluated_to": false,
    "msg": "Ansible must be between 2.15.5 and 2.17.0 exclusive - you have 2.14.6"
}

Introduced in this PR:

Does this PR introduce a user-facing change?:

chore(Dockerfile): python requirements file fixup

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from holmsten December 7, 2023 17:32
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 7, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maxime1907. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from yankay December 7, 2023 17:32
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 7, 2023
@yankay
Copy link
Member

yankay commented Dec 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 8, 2023
@VannTen
Copy link
Contributor

VannTen commented Dec 11, 2023

As far as I can tell, the only thing required to fix the error is mounting the requirements.txt file and using that instead of the package list.
Could you revert or split out the other changes (especially whitespaces only...) ? If there is a need for cleanup of the Dockerfile that should be in another PR.

@maxime1907 maxime1907 force-pushed the fix/dockerfile-dependencies branch 2 times, most recently from 535a866 to 5dee393 Compare December 11, 2023 14:35
@maxime1907 maxime1907 changed the title chore(Dockerfile): python requirements file and best practices chore(Dockerfile): python requirements file Dec 11, 2023
@maxime1907 maxime1907 force-pushed the fix/dockerfile-dependencies branch from 5dee393 to b378ebc Compare December 11, 2023 14:37
@maxime1907
Copy link
Contributor Author

As far as I can tell, the only thing required to fix the error is mounting the requirements.txt file and using that instead of the package list. Could you revert or split out the other changes (especially whitespaces only...) ? If there is a need for cleanup of the Dockerfile that should be in another PR.

done!

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@maxime1907 maxime1907 force-pushed the fix/dockerfile-dependencies branch from b378ebc to 742f1a3 Compare December 11, 2023 15:12
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2023
@maxime1907 maxime1907 force-pushed the fix/dockerfile-dependencies branch from 742f1a3 to 3e7e447 Compare December 11, 2023 15:14
@maxime1907
Copy link
Contributor Author

maxime1907 commented Dec 11, 2023

Done with the review changes!
I have opened another PR for global cleanup here^^:

@VannTen
Copy link
Contributor

VannTen commented Dec 11, 2023

Thanks !
/lgtm
/assign @mzaian
(for approval)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxime1907

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxime1907, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 11, 2023
@maxime1907 maxime1907 force-pushed the fix/dockerfile-dependencies branch from 3e7e447 to 11d4984 Compare December 12, 2023 13:15
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 12, 2023
@maxime1907
Copy link
Contributor Author

Done with the rebase!

@VannTen
Copy link
Contributor

VannTen commented Dec 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 45a070f into kubernetes-sigs:master Dec 12, 2023
64 checks passed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants