-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ansible 2.15 #10481
Update to ansible 2.15 #10481
Conversation
62ae4d1
to
0886a4c
Compare
5608f36
to
728c3c1
Compare
interestingly the ansible upgrade (and not the test deps ugrades) break our test scripts 😭 |
And it seems that we still have an issue with the latest update without. There are some tasks that are not executed (for instance |
ansible-core 2.15.5 that was released today seems to contain our fix for role dependencies. Just need to have a new version of ansible and it should work (hopefully) |
368c7a2
to
f5ba950
Compare
f5ba950
to
76b0704
Compare
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Those doesn't work in Ansible 2.15. Ansible can't load builtin now apparently and these tests are not worth it. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
25661e6
to
06915e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MrFreezeex Thank you man !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@MrFreezeex Thanks /lgtm |
* ansible: upgrade to version >= 2.15.5 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: update requirements Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * contrib/openstack: fix wrong gitignore pattern Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: add missing tzdata requirement Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> * tests: remove some molecules tests Those doesn't work in Ansible 2.15. Ansible can't load builtin now apparently and these tests are not worth it. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]> --------- Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #10375
Special notes for your reviewer:
It also updates tests dependencies as some of our current versions didn't work with 2.15 last time I upgraded those
Does this PR introduce a user-facing change?: