local_path_provisioner: fix invalid podhelper yaml

[MrFreezeex]

What type of PR is this?
/kind bug

What this PR does / why we need it:
New line was not inserted between image and imagePullPolicy for some reasons with the jinja. Simplifying this altogether should fix this.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Should fix recent CI failure after the merge of #10054
Does this PR introduce a user-facing change?:

[local_path_provisioner] Fix invalid podhelper yaml

[MrFreezeex]

^ I cannot explain why the line was not inserted but that's what I got from reading the log of the pod in the CI:

time="2023-06-20T08:27:49Z" level=fatal msg="Error starting daemon: invalid YAMLToJSON the helper pod with helperPodYaml: apiVersion: v1\nkind: Pod\nmetadata:\n  name: helper-pod\nspec:\n  containers:\n  - name: helper-pod\n    image: busybox        imagePullPolicy: IfNotPresent"

So the \n before the last line is clearly missing hopefully this simplification of the jinja fixes it, but no idea why that happened in the first place... AFAIK you need {%- or -%} to influence those sort of things and this is not the case here 🤔

And this should have been caught before the merge of the PR I am also confused how we ended up here in the first place tbh :/

[0ekk]

^ I cannot explain why the line was not inserted but that's what I got from reading the log of the pod in the CI:

time="2023-06-20T08:27:49Z" level=fatal msg="Error starting daemon: invalid YAMLToJSON the helper pod with helperPodYaml: apiVersion: v1\nkind: Pod\nmetadata:\n  name: helper-pod\nspec:\n  containers:\n  - name: helper-pod\n    image: busybox        imagePullPolicy: IfNotPresent"

So the \n before the last line is clearly missing hopefully this simplification of the jinja fixes it, but no idea why that happened in the first place... AFAIK you need {%- or -%} to influence those sort of things and this is not the case here thinking

And this should have been caught before the merge of the PR I am also confused how we ended up here in the first place tbh :/

Because the trim_blocks which the environment variable in Jinja2 is set to True by default on Ansible. https://github.com/ansible/ansible/blob/devel/lib/ansible/plugins/action/template.py#L59

Maybe it can be solved easily this way. https://github.com/ansible/ansible/blob/devel/test/integration/targets/template/tasks/main.yml#L166-L171
Or adding special header to template file like https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/metallb/templates/pools.yaml.j2#L1

[MrFreezeex]

Hmmm I see so the {% if .. %} needed to be on their own line I guess, the version there works and is simpler anyway so that's fine here but thanks for the knowledge! :D

[mzaian]

Thanks for catching this @MrFreezeex

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mzaian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yankay]

Thanks @MrFreezeex

/lgtm