Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update local path provisioner version and remove psp #10054

Merged
merged 2 commits into from
Jun 19, 2023
Merged

update local path provisioner version and remove psp #10054

merged 2 commits into from
Jun 19, 2023

Conversation

liupeng0518
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
update local path provisioner version

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot requested a review from cristicalin May 9, 2023 08:59
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2023
@k8s-ci-robot k8s-ci-robot requested a review from holmsten May 9, 2023 08:59
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2023
@liupeng0518 liupeng0518 force-pushed the update-local-path-provisioner-version branch from 17bdea1 to 256062f Compare May 12, 2023 01:25
@liupeng0518
Copy link
Member Author

/retest

@liupeng0518 liupeng0518 reopened this May 17, 2023
@liupeng0518 liupeng0518 force-pushed the update-local-path-provisioner-version branch from 256062f to e73d8dc Compare May 17, 2023 07:29
@mzaian
Copy link
Contributor

mzaian commented May 22, 2023 •
edited
Loading

Hello @liupeng0518

Thank you for the PR. What do you think about synchronising with https://raw.githubusercontent.com/rancher/local-path-provisioner/v0.0.24/deploy/local-path-storage.yaml e.g updating the manifests and removing the PodSecurityPolicy manifest because it's removed in Kubernetes v1.25.

PodSecurityPolicy was [deprecated](https://kubernetes.io/blog/2021/04/08/kubernetes-1-21-release-announcement/#podsecuritypolicy-deprecation) in Kubernetes v1.21, and removed from Kubernetes in v1.25.

Partly connected to #10018

Ref: https://kubernetes.io/docs/concepts/security/pod-security-policy/

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2023
@liupeng0518 liupeng0518 changed the title update local path provisioner version update local path provisioner version and remove psp May 26, 2023
@MrFreezeex
Copy link
Member

MrFreezeex commented May 26, 2023 •
edited
Loading

Hi you need to rebase your PR to fix the CI issue, looks good to me apart from that 👍, thanks!

@liupeng0518 liupeng0518 force-pushed the update-local-path-provisioner-version branch 2 times, most recently from 708af5b to a558c55 Compare May 30, 2023 01:22
@liupeng0518
Copy link
Member Author

/retest

mzaian
mzaian approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @liupeng0518

MrFreezeex
MrFreezeex approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks as well 🙏, you would probably need to fully rekick the CI though if someone is not able to relaunch the failing job 🙈
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liupeng0518, MrFreezeex, mzaian, r0b2g1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liupeng0518
Copy link
Member Author

/test all

@liupeng0518
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@liupeng0518 liupeng0518 force-pushed the update-local-path-provisioner-version branch from a558c55 to f20c1b5 Compare June 16, 2023 11:55
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 16, 2023
@MrFreezeex
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit db69678 into kubernetes-sigs:master Jun 19, 2023
This was referenced Jun 20, 2023
Merged
Merged
maciej-markowski pushed a commit to maciej-markowski/kubespray that referenced this pull request Jun 23, 2023
@liupeng0518 @maciej-markowski
update local path provisioner version and remove psp (kubernetes-sigs…
92ce75b 
…#10054)

* update local_path_provisioner_version

* remove psp and update cm
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@liupeng0518 @pedromcpedro
update local path provisioner version and remove psp (kubernetes-sigs…
14e8e7a 
…#10054)

* update local_path_provisioner_version

* remove psp and update cm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0b2g1t r0b2g1t r0b2g1t approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@mzaian mzaian mzaian approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liupeng0518 @mzaian @MrFreezeex @k8s-ci-robot @r0b2g1t