-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc certmanager 0.11 group and version change #1444
Update doc certmanager 0.11 group and version change #1444
Conversation
from certmanager.k8s.io/v1alpha1 to cert-manager.io/v1alpha2. Signed-off-by: JenTing Hsiao <[email protected]>
Hi @jenting. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @jenting! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
It shows ok for me. Let's looking for a second check from a trusted reviewer as well to see it get merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jenting,
This change also needs to be reflected in the book-v2 branch. See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/CONTRIBUTING.md#how-to-contribute-to-docs
Could you please create the PR for we are able to move forward with?
wdyt @Adirio ?
@camilamacedo86, sure~ but I thought someone (maybe release owner) would help me merge the changes from the master branch into the book-v2 branch.
|
My understand that is: If we do some change that should be reflected in the production docs. E.g a fix over something that is outdated there we need also to do a PR for book-v2. However, it is fine. I will check it with @mengqiy and do in this case if required. So: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, jenting The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubebuilder-e2e-k8s-1-16-2 |
@camilamacedo86 After re-reading
Open a cherry-pick PR #1453. |
Update documentation for certmanager 0.11 group and version change.
Change from certmanager.k8s.io/v1alpha1 to cert-manager.io/v1alpha2.
Fixes #1434
Signed-off-by: JenTing Hsiao [email protected]