Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Extract Resource from the v1 scaffolding package #1159

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Nov 6, 2019

Description

Move Resource and associated tests one package above.

Motivation

Extract common functionality out of the v1 specific dir, what should help deprecating v1 (#1136).

Fixes #1144

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Adirio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 6, 2019
@Adirio
Copy link
Contributor Author

Adirio commented Nov 6, 2019

/kind feature

/assign @DirectXMan12

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 6, 2019
@mengqiy
Copy link
Member

mengqiy commented Nov 8, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2019
@mengqiy mengqiy closed this Nov 8, 2019
@mengqiy mengqiy reopened this Nov 8, 2019
@mengqiy
Copy link
Member

mengqiy commented Nov 8, 2019

/lgtm
/approve
Thanks for cleanup things

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2019
@mengqiy mengqiy changed the title Extract Resource from the v1 scaffolding package 🏃 Extract Resource from the v1 scaffolding package Nov 8, 2019
@Adirio
Copy link
Contributor Author

Adirio commented Nov 11, 2019

Travis is failing because of a checksum of k8s.io/apimachinery. I didn't make any change related to that. Any clue why this may be happening?

EDIT: seems to be related to #1169

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2019
@Adirio
Copy link
Contributor Author

Adirio commented Nov 11, 2019

I rebased and force-pushed to see if #1135 solves the Travis issue. Could you add /lgtm label again @mengqiy? Sorry for the inconveniences.

@mengqiy mengqiy closed this Nov 11, 2019
@mengqiy mengqiy reopened this Nov 11, 2019
@mengqiy
Copy link
Member

mengqiy commented Nov 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit 977ce8b into kubernetes-sigs:master Nov 12, 2019
@Adirio Adirio deleted the extract-resource branch November 12, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Resource from the v1 Scaffolding package
4 participants