-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Extract Resource from the v1 scaffolding package #1159
Conversation
Hi @Adirio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature /assign @DirectXMan12 |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Travis is failing because of a checksum of k8s.io/apimachinery. I didn't make any change related to that. Any clue why this may be happening? EDIT: seems to be related to #1169 |
Signed-off-by: Adrian Orive <[email protected]> kubernetes-sigs#1144
Signed-off-by: Adrian Orive <[email protected]>
b9c1a68
to
4d63aef
Compare
/lgtm |
Description
Move
Resource
and associated tests one package above.Motivation
Extract common functionality out of the
v1
specific dir, what should help deprecating v1 (#1136).Fixes #1144