Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Resource from the v1 Scaffolding package #1144

Closed
Adirio opened this issue Oct 31, 2019 · 1 comment · Fixed by #1159
Closed

Extract Resource from the v1 Scaffolding package #1144

Adirio opened this issue Oct 31, 2019 · 1 comment · Fixed by #1159
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Adirio
Copy link
Contributor

Adirio commented Oct 31, 2019

The Resource type is being used by both scaffolding versions, but it is placed inside v1, which is missleading. Furthermore, v1 scaffolding is being deprecated (#1136, #1137).

Shouldn't this package be extracted to the root scaffolding package?

/kind feature
@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 31, 2019
@Adirio Adirio mentioned this issue Nov 5, 2019
Merged
@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Nov 6, 2019 •
edited
Loading

yeah, it should be.

Adirio added a commit to Adirio/kubebuilder that referenced this issue Nov 6, 2019
@Adirio
Extract Resource from v1 specific package
26f2dec 
Signed-off-by: Adrian Orive <[email protected]>

kubernetes-sigs#1144
@Adirio Adirio mentioned this issue Nov 6, 2019
Merged
Adirio added a commit to Adirio/kubebuilder that referenced this issue Nov 11, 2019
@Adirio
Extract Resource from v1 specific package
f4c81fe 
Signed-off-by: Adrian Orive <[email protected]>

kubernetes-sigs#1144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🏃 Extract Resource from the v1 scaffolding package Adirio/kubebuilder
2 participants
@DirectXMan12 @Adirio