-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect path for Kustomize in addon operators #91
Fix incorrect path for Kustomize in addon operators #91
Conversation
@rajansandeep This PR changes private "Reconciler.options" with public "Reconciler.Options", I know the reason do that. But, we should minimize a range which can access to variable, I think. @justinsb |
a7968bc
to
69b4467
Compare
update tests
69b4467
to
eab0d02
Compare
/cc @johnsonj |
Thank you @rajansandeep ! I think @atoato88 's feedback was addressed by the getter. I think this is a good approach. Please raise if that didn't solve it. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnsonj, rajansandeep The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kustomize cannot find the
kustomization.yaml
file for creating the final manifest.The error before this fix:
This PR fixes the error and also updates the test to reflect the case where an operator uses Kustomize
Probable related issue: #56