Upgrade CoreDNS-Operator to v2 #50
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
|
/cc @johnsonj |
|
The Kustomize support complies using patch from kubernetes-sigs/kubebuilder-declarative-pattern#91 Edit: Both kubernetes-sigs/kubebuilder-declarative-pattern#91 and kubernetes-sigs/kubebuilder-declarative-pattern#94 are merged and included in "master" |
rajansandeep
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
rajansandeep
force-pushed
the
coredns-operator-v2
branch
from
bb6c673 to
286f134
Compare
…r version 2 some cleanup, add 1.3.1 coredns, make operator run in-cluster add basic golden test add more golden test and made minor nits support kustomize, add coredns migration logic and add some tests update golden-test result and update go mod
rajansandeep
force-pushed
the
coredns-operator-v2
branch
from
286f134 to
8e80324
Compare
|
/assign @johnsonj |
|
wohoo! will do- thank you @rajansandeep ! |
There was a problem hiding this comment.
@rajansandeep - This looks fantastic. The migration implementation is straightforward and clear. This is exactly the use-case that makes the operator shine. I appreciate your digging and fixes to get kustomize in kubebuilder-declarative-pattern working! The testing looks great as well.
I'd suggest in this change (or another) to beef up the README since this thing is no toy now!
coredns/Makefile
Outdated
| @@ -1,66 +1,85 @@ | |||
|
|
|||
| # Image URL to use all building/pushing image targets | |||
| IMG ?= ${USER}/coredns-operator:latest | |||
| IMG ?= rajansandeep/coredns-operator:latest | |||
There was a problem hiding this comment.
nit: revert back to ${USER}
@johnsonj, Definitely! I think the README should be focusing on "How to use/install" the operator than "How to create". I'll make those changes in a separate PR. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnsonj, rajansandeep The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The CoreDNS operator is built using Kubebuilder v2.3 and a bug fix which fixes the plugin addon template.
Edit: Since then v2.3.1 has been released which includes the bug fix
This replaces the existing v1 operator
(If the changes here are confusing due to file overlap, or we prefer to keep v1, I can make these changes to a different directory)
I have also updated the CoreDNS version to 1.6.7 (Current latest)
TODO:
Fixes: #24