-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to update kubeconfig #790
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barkbay The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @barkbay. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should discuss this in an issue I think, there's some design and tradeoffs involved. The users field is going to collide if multiple kind clusters are created IIRC. This is definitely a neat feature, but it can also be accomplished with a tiny bit of |
I have created #802
Yes, this PR takes care of that by adding the cluster name as a suffix.
👍 makes sense
Agreed |
This is done by default now in a way that closely marches other tools. Ref #850 |
This feature is motivated by the fact that most of our current deployments (minikube, gke ...) are managed through the default kubeconfig file.
It might also be convenient for people that use tools like kubecxt.
With this PR user can add
--set-context
when a cluster is created to import the new context to its kubeconfig.Note that it does not remove the context when the cluster is deleted, but it can be done in an other PR (I wanted to keep this one small).
Also I'm not sure about the unit test policy, I can add some of them to at least cover the merge with the current kubeconfig (could also be done in an other PR)
Let me know your thoughts.
This PR supersedes: