Modify kubeconfig by using client-go, not regex

[marckhouzam]

This commit uses k8s.io/client-go to modify the kubeconfig
file to use a localhost server.

Signed-off-by: Marc Khouzam [email protected]

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marckhouzam
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bentheelder

If they are not already assigned, you can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @marckhouzam. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[marckhouzam]

@BenTheElder I made the assumption that Kind was targeting a single kubernetes version, but now I'm thinking that is not correct.

If Kind supports multiple versions of Kubernetes, then I'm not sure it is possible to use client-go, as I believe we need to choose which version of client-go to use based on the version of Kubernetes. What do you think?

[aojea]

reading the Versioning chapter of the README they are following semver so I think that we should use latest stable tag? in this case is v1.11.0
What do you think?

[marckhouzam]

@aojea you're right that v1.11.0 would be better. I'm just not sure if all versions of kubernetes have the same data structure to read the kubeconfig file. So if Kind prepared a cluster for, say, k8s v1.10, will client-go v1.11 still work?

I'm out of my depth here...

[BenTheElder]

kind indeed supports multiple versions of kubernetes. out of the box there is a default version, but kind's initial support was (and is) actually for developing kubernetes, where we may be building fairly arbitrary (v1.11+) versions of kubernetes and then running them with kind.

[neolit123]

I'm just not sure if all versions of kubernetes have the same data structure to read the kubeconfig file

the client-go Config type is unlikely to change anytime soon. if it does, v1 will be supported for a long period of time. thus using any recent version of client-go/tools/clientcmd should be fine.

[k8s-ci-robot]

@marckhouzam: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BenTheElder]

/ok-to-test

[munnerz]

This looks good, I added a few comments 😄 thanks!

[munnerz]

I'd expect that k8s.io/apimachinery, k8s.io/api and potentially even k8s.io/klog are bumped in the go.sum file after this change? It seems like go mod tidy (or hack/update-vendor.sh) needs running 😄

[munnerz]

nit: external imports should exist in the 2nd block (after stdlib imports but before imports within this module)

[munnerz]

(I'm not too familiar here, so please excuse my question if it's a stupid one!) why the switch from CombinedOutputLines to Output?

[k8s-ci-robot]

@marckhouzam: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kind-verify	d21c9f5	link	/test pull-kind-verify
pull-kind-build	d21c9f5	link	/test pull-kind-build
pull-kind-conformance-parallel-1-14	d21c9f5	link	/test pull-kind-conformance-parallel-1-14
pull-kind-conformance-parallel-1-13	d21c9f5	link	/test pull-kind-conformance-parallel-1-13
pull-kind-conformance-parallel-1-12	d21c9f5	link	/test pull-kind-conformance-parallel-1-12
pull-kind-conformance-parallel	d21c9f5	link	/test pull-kind-conformance-parallel
pull-kind-conformance-parallel-1-15	d21c9f5	link	/test pull-kind-conformance-parallel-1-15
pull-kind-unit	d21c9f5	link	/test pull-kind-unit
pull-kind-conformance-parallel-1-16	d21c9f5	link	/test pull-kind-conformance-parallel-1-16
pull-kind-e2e-kubernetes	d21c9f5	link	/test pull-kind-e2e-kubernetes

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[BenTheElder]

thanks again for the PR, we've removed client-go as a direct or indirect dependency for the kind binary which makes it easier to import in the future and the binary much smaller.

I'm going to look at doing something similar without client-go but without regex as part of #850

[marckhouzam]

Sorry for losing track of this.
I'll be checking out #850.