-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new portmap plugin #1720
use new portmap plugin #1720
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aojea The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority critical-urgent |
/hold |
just validating hypothesis |
this didn't run is and is the more prone to show the errors nothing in the finished jobs so far 🤞 |
promising, no trace (I'm almost crying 😄 one year chasing this and we are so close) |
ok, we got it, no deadlock errors again |
ok, after 3 rounds and 6 different jobs not locking problems, I think that this time we can confirm the portmap plugin was the one causing the iptables locking problem |
This will break the kube e2e tests that use kind won't it? |
there are no hostPort e2e tests, at least I didn't find them 🤷 |
/test all |
clone containernetworking/plugins#509 ./build docker build FROM kindest/base:v20200707-e647846b COPY bin/portmap /opt/cni/bin/portmap
here we go, with the fix here containernetworking/plugins#509 |
pull-kind-e2e-kubernetes and pull-kind-e2e-kubernetes-1-18 and ipv6 clean |
/test all |
1 similar comment
/test all |
@aojea: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@BenTheElder this is ready to go, what will be the best way to include the plugin with the fix meanwhile is not merged in CNI? |
maybe we can build the CNI plugins in a multi-step base-image dockerfile from your fork? With a TODO to switch to upstream once merged, and to switch to just consuming the release binaries once released. |
/close |
@aojea: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
the portmap plugin is buggy on deletion, it just blindly tries to
delete everything once it gets a DEL, no matter the IP family.
Added to the problem caused because it is being executed with the
-w option without any timeout (see go-iptables), it may hold the
lock or cause contention, making all services in the cluster to
fail.
Use the new portmap version
containernetworking/plugins#509