portmap should not perform deletions if not portMapping config received #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @dcbw @bboreham |
aojea
changed the title
if the runtime is not passing portMappings in the runtimeConfig, then DEL is a noop. This solves performance issues, when the portmap plugin is executed multiple times, holding the iptables lock, despite it does not have anything to delete. Signed-off-by: Antonio Ojea <[email protected]>
This was referenced Jul 13, 2020
aojea
pushed a commit
to aojea/kind
that referenced
this pull request
Jul 13, 2020
clone containernetworking/plugins#509 ./build docker build FROM kindest/base:v20200707-e647846b COPY bin/portmap /opt/cni/bin/portmap
aojea
pushed a commit
to aojea/kind
that referenced
this pull request
Jul 13, 2020
clone containernetworking/plugins#509 ./build docker build FROM kindest/base:v20200707-e647846b COPY bin/portmap /opt/cni/bin/portmap
aojea
pushed a commit
to aojea/kind
that referenced
this pull request
Jul 14, 2020
clone containernetworking/plugins#509 ./build docker build FROM kindest/base:v20200707-e647846b COPY bin/portmap /opt/cni/bin/portmap
bboreham
approved these changes
Jul 15, 2020
matthewdupre
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The portmap plugin, once receives a DEL, tries to delete as much as possible.
This causes issues on busy environment, because all DEL command are going to be processed by the portmap plugin, that will perform iptables operations holding the lock despite it doesn't have anything to delete.
portmap should only try to delete if it receives portMap parameters from the runtimeConfig.
xref: kubernetes/kubernetes#92811 (comment)
Fixes: #510
Signed-off-by: Antonio Ojea [email protected]