Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix tejolote release attestation step #914

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Dec 26, 2023

Fixes #N/A

Description

Fixes a failure generated by the release attestation added here: #889 by ensuring that we generate the attestation for the release after we have created the release.

How was this change tested?

Manually tagging and generate attestation in fork

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 26, 2023
@jonathan-innis jonathan-innis force-pushed the fix-tejolote-release-step branch 2 times, most recently from 32ba45d to 194ca59 Compare December 26, 2023 23:37
@coveralls
Copy link

coveralls commented Dec 26, 2023

Pull Request Test Coverage Report for Build 7333510100

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.071%

Totals Coverage Status
Change from base Build 7326972508: 0.0%
Covered Lines: 7630
Relevant Lines: 9529

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the fix-tejolote-release-step branch from 194ca59 to 7e66968 Compare December 27, 2023 00:00
Copy link
Contributor

@engedaam engedaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit d4ff37c into kubernetes-sigs:main Dec 27, 2023
11 checks passed
@jonathan-innis jonathan-innis deleted the fix-tejolote-release-step branch December 27, 2023 00:22
nikmohan123 pushed a commit to nikmohan123/karpenter that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants