-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure SLSA Attestations are Generated when Possible #889
Conversation
Signed-off-by: coder12git <[email protected]>
Signed-off-by: coder12git <[email protected]>
This reverts commit 252e6b6.
Hi @coder12git. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 7326865305Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
https://github.com/kubernetes-sigs/karpenter/actions/runs/7258678139 |
Signed-off-by: coder12git <[email protected]>
Done the changes |
/ok-to-test |
@coder12git have you confirmed @sreeram-venkitesh no longer intents to work on this task? I think it's best to confirm with the previous assignee before |
Yeah it's fine! |
I got caught up with some work in my day job and hence couldn't look into this. Thanks @coder12git for raising the PR, you can go ahead with this task! |
any update here? |
I think the CI checks are passing, and maybe we are good to merge this now, isn't it? |
From my side, yes.. I have also attached the output of the file |
Signed-off-by: coder12git <[email protected]>
Signed-off-by: coder12git <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coder12git, jonathan-innis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the work here @coder12git! Awesome to see these security slam tasks getting knocked out! |
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
…#889) Signed-off-by: coder12git <[email protected]>
Fixes #876
Task-4
- Security SlamDescription
This PR ensure SLSA Attestations are Generated when Possible. Checkout this doc for reference.
// @jonathan-innis
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.