-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor project layout to enable multiple providers #40
Refactor project layout to enable multiple providers #40
Conversation
Hi @levikobi. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @levikobi, thats an important piece of work!
The approach is LGTM but left some comments.
Also, any specific reason you wrapped all the errors with %w
? I did not find error types in this PR so not sure whats the value of the wrapping
/cc |
As discussed offline, the %w doesn't add value right now. I will revert to %v. |
/cc |
d54ed81
to
621bf56
Compare
Havent had time to look after the new commits yet but since we gonna have contour and istio implementing the provider specific logic first I would like another review from @howardjohn and @sunjayBhatia |
pkg/i2gw/ingress2gateway.go
Outdated
} | ||
} | ||
|
||
// TODO: Open a new issue - collate gateways objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please open an issue for it and then put the issue num in the parenthesis.
TODO(<issue_number>) collate gateways objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this one, but I recommend also putting the person who logged the TODO right there if we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave it a second thought, and I'm actually not sure we will need to collate the different resources that providers will generate.
Say we have 2 providers that each returned one gateway
, they should not be merged into a single gateway
.
So basically I think we can remove this todo altogether without opening a new issue, but please let me know if you disagree.
e856338
to
52d6f90
Compare
52d6f90
to
ad83255
Compare
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for you hard work @levikobi !
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: levikobi, LiorLieberman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/kind feature
What this PR does / why we need it:
Adding support for converting multiple Ingress providers, in an extensible and testable way.
Which issue(s) this PR fixes:
Fixes #28
Does this PR introduce a user-facing change?: