Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate commonly used nginx ingress annotations #52

Closed
3 tasks
Treenhan opened this issue Aug 16, 2023 · 5 comments
Closed
3 tasks

Investigate commonly used nginx ingress annotations #52

Treenhan opened this issue Aug 16, 2023 · 5 comments
Assignees
@Treenhan
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Treenhan
Copy link
Contributor

Treenhan commented Aug 16, 2023 •
edited by LiorLieberman
Loading

Currently, only a small set of nginx ingress annotations are supported. We would like to:

  • Investigate and document what are the the most important and commonly used annotations from the complete list available at https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/annotations/
  • Create separate issues to support different logical groups of annotations (meaning the tool can parse them and convert them into similar gateway/HTTPRoute features)
  • Explain how the conversion process works in our documentation.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 16, 2023
@Treenhan
Copy link
Contributor Author

@LiorLieberman can I get assigned?

@Treenhan
Copy link
Contributor Author

/assign @Treenhan

@LiorLieberman LiorLieberman changed the title Support complete set of nginx ingress annotations Investigate commonly used nginx ingress annotations Aug 17, 2023
@LiorLieberman
Copy link
Member

@Treenhan made some changes to the description and the title. FYI.

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Aug 17, 2023
@LiorLieberman
Copy link
Member

@Treenhan just checking in, do you still plan to work on this ? Let us know if you need any help

@Treenhan
Copy link
Contributor Author

Hi @LiorLieberman, I think this feature is not as important as it used to be now that v0.1.0 is released, I will deprioritize this and focusing on fixing issues.

@LiorLieberman LiorLieberman closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Treenhan Treenhan

Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k8s-ci-robot @Treenhan @LiorLieberman