Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm webhook resources from installation yaml #2401

Merged

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Sep 15, 2023

What type of PR is this?

Fixes # #2400

Does this PR introduce a user-facing change?:

Resources related to the validating webhook such as the `gateway-system` namespace and the `gateway-api-admission-server` deployment have been removed from the installation manifests, in favor of CEL based Validations that are built into the CRD definition. These are still available in `webhook-install.yaml` in case you would like to optionally install them.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2023
@shaneutt shaneutt added this to the v1.0.0 milestone Sep 15, 2023
@shaneutt shaneutt added the release-blocker MUST be completed to complete the milestone label Sep 15, 2023
Add a seperate `webhook-install.yaml` file instead
which contains only webhook resources which someone
may choose to optionally install

Fixes: kubernetes-sigs#2400

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg force-pushed the rm-admission-server-install branch from 18102b6 to 67dd2fb Compare September 15, 2023 17:33
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2023
@robscott
Copy link
Member

Thanks @arkodg!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit cd223ea into kubernetes-sigs:main Sep 15, 2023
4 checks passed
@arkodg arkodg deleted the rm-admission-server-install branch September 15, 2023 17:58
bartsmykla added a commit to bartsmykla/kuma-website that referenced this pull request Apr 15, 2024
- Gateway API doesn't need to be installed in Experimental
  Channel anymore, as we are not supporting any of experimental
  features yet, so I changed the instruction to reflect that.
- Admission Webhook doesn't come with CRDs anymore, so we can
  safely stop mentioning it
  (re. kubernetes-sigs/gateway-api#2401)

Signed-off-by: Bart Smykla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-blocker MUST be completed to complete the milestone release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Provide install manifests that do not contain the gateway-api admission server
4 participants