Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide install manifests that do not contain the gateway-api admission server #2400

Closed
arkodg opened this issue Sep 15, 2023 · 11 comments · Fixed by #2401
Closed

Provide install manifests that do not contain the gateway-api admission server #2400

arkodg opened this issue Sep 15, 2023 · 11 comments · Fixed by #2401
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker MUST be completed to complete the milestone
Milestone

Comments

@arkodg
Copy link
Contributor

arkodg commented Sep 15, 2023

What would you like to be added:
A release artifact similar to https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.8.1 which contains the installation manifests for Gateway API CRDs and not the Gateway API admission server and related resources

Why this is needed:

Installing the Gateway API admission server is optional and all its functionality has been replaced by CEL validations
https://kubernetes.io/blog/2023/08/29/gateway-api-v0-8/#cel-validation

@arkodg arkodg added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 15, 2023
@robscott robscott added this to the v1.0.0 milestone Sep 15, 2023
@robscott robscott added the release-blocker MUST be completed to complete the milestone label Sep 15, 2023
@shaneutt shaneutt moved this from Triage to Next in Gateway API: The Road to GA Sep 15, 2023
@shaneutt shaneutt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 15, 2023
@shaneutt
Copy link
Member

shaneutt commented Sep 15, 2023

Is this kind of a part of #2319? We could merge them as it would seem reasonable for one body of work to take care of both at the same time.

@arkodg
Copy link
Contributor Author

arkodg commented Sep 15, 2023

@shaneutt yes its related to #2319, but imo having a smaller work item is much easier to track and assign to a community contributor

looks like https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh needs to be updated to accomplish this goal, the question is around naming and content - should we just create a experimental-crds-install.yaml & standard-crds-install.yaml and keep the existing experimental-install.yaml & standard-install.yaml as is ?

@shaneutt
Copy link
Member

@shaneutt yes its related to #2319, but imo having a smaller work item is much easier to track and assign to a community contributor

👍

looks like https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh needs to be updated to accomplish this goal, the question is around naming and content - should we just create a experimental-crds-install.yaml & standard-crds-install.yaml and keep the existing experimental-install.yaml & standard-install.yaml as is ?

I'm not sure we should start having all these extras laying around, I think we should just remove the admission server bits and be done with it, v0.8.0 (the last release intended to "support" the webhook) is branched and any future webhook development should probably be isolated to that branch.

@arkodg
Copy link
Contributor Author

arkodg commented Sep 15, 2023

cool @shaneutt, I can take care of this
/assign @arkodg

arkodg added a commit to arkodg/gateway-api that referenced this issue Sep 15, 2023
@shaneutt shaneutt linked a pull request Sep 15, 2023 that will close this issue
@shaneutt shaneutt moved this from Next to In Progress in Gateway API: The Road to GA Sep 15, 2023
@shaneutt shaneutt removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 15, 2023
@robscott
Copy link
Member

robscott commented Sep 15, 2023

I'm not sure we should start having all these extras laying around, I think we should just remove the admission server bits and be done with it, v0.8.0 (the last release intended to "support" the webhook) is branched and any future webhook development should probably be isolated to that branch.

Unfortunately per #2319 we still actually need to keep the webhook around in v1.0. Because we've committed to supporting 5 trailing Kubernetes versions, we need to wait until v1.29 is live to fully drop the webhook. It looks like that is currently scheduled for Dec 5, and of course we want to launch v1.0 by the end of October. My suggestion would be for the default installation method to exclude the webhook starting in v1.0, but I think we still need to leave it around for that release and provide a way to install it as an add-on for 1.24 clusters.

@shaneutt
Copy link
Member

Ah, yeah this had slipped my mind, and it's true so sorry about that @arkodg but I guess we can't get away with a toss in the bin on this one.

@arkodg
Copy link
Contributor Author

arkodg commented Sep 15, 2023

Cool, waiting for specific guidance on this before continuing any further

@arkodg
Copy link
Contributor Author

arkodg commented Sep 15, 2023

@robscott two options here, for each of standard and experimental, we have two install manifests

  • crds-install & webhook-install
    OR
  • crds-install & all-install (this file exists today)

which one do you prefer ?

@robscott
Copy link
Member

Thanks @arkodg! Currently each release has experimental-install.yaml and standard-install.yaml files, I think we should keep those going forward, but remove the webhook from them and instead add a short-lived (v1.0 only) webhook-install.yaml, does that make sense? (The webhook installation is the same regardless of release channel).

I think the result would just be a relatively simple change to https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh.

Maybe you were talking about different files than I was though, so let me know if I missed something.

@shaneutt
Copy link
Member

I'm on board with that too 👍

@arkodg
Copy link
Contributor Author

arkodg commented Sep 15, 2023

Thanks @arkodg! Currently each release has experimental-install.yaml and standard-install.yaml files, I think we should keep those going forward, but remove the webhook from them and instead add a short-lived (v1.0 only) webhook-install.yaml, does that make sense? (The webhook installation is the same regardless of release channel).

I think the result would just be a relatively simple change to https://github.com/kubernetes-sigs/gateway-api/blob/main/hack/build-install-yaml.sh.

Maybe you were talking about different files than I was though, so let me know if I missed something.

sgtm, on it !

arkodg added a commit to arkodg/gateway-api that referenced this issue Sep 15, 2023
Add a seperate `webhook-install.yaml` file instead
which contains only webhook resources which someone
may choose to optionally install

Fixes: kubernetes-sigs#2400

Signed-off-by: Arko Dasgupta <[email protected]>
@github-project-automation github-project-automation bot moved this from In Progress to Done in Gateway API: The Road to GA Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker MUST be completed to complete the milestone
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants