update regex to comply with RFC-3986

[jackstine]

Description

Adding [%][0-9a-fA-F]{2} as an option to find Hex values. Also adding @ as a value to find as well.
The subset of single characters can be selected in addition to the set of all Hex values, hence the (?:<pattern1>|<pattern2>)

What type of PR is this?
/kind bug

What this PR does / why we need it:
Complies with RFC-3986 "p-char" characters.

Which issue(s) this PR fixes:
Updates this PR #1599

Does this PR introduce a user-facing change?:
It might, but not really.

update route validation to comply with RFC-3986 "p-char" characters.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jackstine / name: Jacob Cukjati (12dec58)

[k8s-ci-robot]

Welcome @jackstine!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jackstine. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jackstine]

Adding @robscott here because he initially worked on the PR #1599

[robscott]

Thanks for catching this @jackstine!

Just want to make sure I'm understanding both changes correctly:

1. Per RFC-3986. pchar = unreserved / pct-encoded / sub-delims / ":" / "@". My initial regex missed both : and @, this fixes that.
2. Per the same RFC, % is only valid as part of pct-encoded = "%" HEXDIG HEXDIG, this enforces that restriction.

Does that line up with what you're thinking? Did I miss anything?

/ok-to-test

[jackstine]

Hey @robscott that is exactly right. Also : was already included.

[robscott]

Makes sense, thanks @jackstine! Will defer to someone else to LGTM.

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackstine, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [robscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[youngnick]

/lgtm

[dprotaso]

Any chance we could add a unit test for the regexp change?

[robscott]

@dprotaso that seems like a good idea. So far the only way we've tested CRD validation is by adding valid examples to /examples and invalid examples to /hack/invalid-examples. We then rely on hack/verify-examples-kind.sh to check that the valid examples pass validation and the invalid ones don't. Probably worth filing an issue to track this.