Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Invalid/Valid Path Characters #1658

Closed
dprotaso opened this issue Jan 19, 2023 · 3 comments · Fixed by #1659
Closed

Test Invalid/Valid Path Characters #1658

dprotaso opened this issue Jan 19, 2023 · 3 comments · Fixed by #1659
Assignees
@em-r
Labels
kind/test
Milestone
v0.7.0

Comments

@dprotaso
Copy link
Contributor

@dprotaso that seems like a good idea. So far the only way we've tested CRD validation is by adding valid examples to /examples and invalid examples to /hack/invalid-examples. We then rely on hack/verify-examples-kind.sh to check that the valid examples pass validation and the invalid ones don't. Probably worth filing an issue to track this.

Originally posted by @robscott in #1644 (comment)
@dprotaso
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 19, 2023
@em-r
Copy link
Contributor

em-r commented Jan 20, 2023

/assign

em-r added a commit to em-r/gateway-api that referenced this issue Jan 20, 2023
@em-r
test: path characters regexp validation (kubernetes-sigs#1658)
47c43be
@em-r em-r mentioned this issue Jan 20, 2023
Merged
@Xunzhuo
Copy link
Member

Xunzhuo commented Mar 8, 2023

/remove-help

@k8s-ci-robot k8s-ci-robot removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Mar 8, 2023
@shaneutt shaneutt added this to the v0.7.0 milestone Mar 8, 2023
@shaneutt shaneutt moved this to In Progress in Gateway API: The Road to GA Mar 8, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Gateway API: The Road to GA Mar 8, 2023
@shaneutt shaneutt mentioned this issue Jul 24, 2023
Closed
@shaneutt shaneutt mentioned this issue Aug 7, 2023
Closed
@shaneutt shaneutt mentioned this issue Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@em-r em-r

Labels
kind/test
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

test: path characters regexp validation em-r/gateway-api
5 participants
@dprotaso @shaneutt @em-r @k8s-ci-robot @Xunzhuo