Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix go versions in go modules #2722

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module sigs.k8s.io/controller-runtime

go 1.22.0
go 1.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest. Not sure what we should do here. We won't be able to get CI green if go mod tidy changes the go mod file. I also don't want to check in a go.mod file that is updated as soon as a go command is run

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded on the issue: #2720 (comment) (just saw the comments there now)


require (
github.com/evanphx/json-patch v4.12.0+incompatible // Using v4 to match upstream
Expand Down
2 changes: 1 addition & 1 deletion tools/setup-envtest/go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module sigs.k8s.io/controller-runtime/tools/setup-envtest

go 1.22.0
go 1.22

require (
github.com/go-logr/logr v1.2.4
Expand Down
Loading