Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix go versions in go modules #2722

Closed
wants to merge 1 commit into from

Conversation

fspaniol
Copy link

@fspaniol fspaniol commented Mar 22, 2024

Related to #2720.

I have tried go get locally and I was getting the following errors before:

invalid go version '1.22.0': must match format 1.23

With this change, this is solved.

To provide more context on to why this happens:

I have a local setup where I use go 1.20 but however was installing envtest using the latest reference.

After opening this PR, as a mean of trying out, I upgraded my local Go version to 1.22, and go get worked with the current HEAD version. And if I execute it with this PR's state, it even changed it to 1.22.0 again:

go get .
go: upgraded go 1.22 => 1.22.0
go: added toolchain go1.22.1

Now, for whomever has older Go versions, using the current main will not work, but on the other hand, if we merge this, it will always modify the go.mod for people with newer go versions. I'll defer to the maintainers on what's the wanted approach here.

As I said, in my project I switched from @latest to @release-0.16 and I can move on.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fspaniol
Once this PR has been reviewed and has the lgtm label, please assign sbueringer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @fspaniol. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2024
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 23, 2024
@k8s-ci-robot
Copy link
Contributor

@fspaniol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-test 9549e2f link true /test pull-controller-runtime-test
pull-controller-runtime-apidiff 9549e2f link false /test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -1,6 +1,6 @@
module sigs.k8s.io/controller-runtime

go 1.22.0
go 1.22
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest. Not sure what we should do here. We won't be able to get CI green if go mod tidy changes the go mod file. I also don't want to check in a go.mod file that is updated as soon as a go command is run

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded on the issue: #2720 (comment) (just saw the comments there now)

gbenhaim added a commit to gbenhaim/build-service that referenced this pull request Mar 24, 2024
The latest version introduced a bug that broke the CI -
kubernetes-sigs/controller-runtime#2722

In general it's better to use specific versions for the dependencies,
so their update can be tested in the CI.

Signed-off-by: gbenhaim <[email protected]>
gbenhaim added a commit to gbenhaim/build-service that referenced this pull request Mar 24, 2024
The latest version introduced a bug that broke the CI -
kubernetes-sigs/controller-runtime#2722

In general it's better to use specific versions for the dependencies,
so their update can be tested in the CI.

Signed-off-by: gbenhaim <[email protected]>
gbenhaim added a commit to gbenhaim/build-service that referenced this pull request Mar 24, 2024
The latest version introduced a bug that broke the CI -
kubernetes-sigs/controller-runtime#2722

In general it's better to use specific versions for the dependencies,
so their update can be tested in the CI.

Signed-off-by: gbenhaim <[email protected]>
gbenhaim added a commit to konflux-ci/repository-validator that referenced this pull request Mar 25, 2024
The latest version has a bug in it kubernetes-sigs/controller-runtime#2722

Signed-off-by: gbenhaim <[email protected]>
mmorhun pushed a commit to konflux-ci/build-service that referenced this pull request Mar 25, 2024
* RHTAPSRE-467: Update application-service version

In order to get the changes introduced in
redhat-appstudio/application-service#450,
update the application service version.

In the new version some of the function moved between modules, so fixing
the import paths for those.

In addition, when of the assertions looked for an error message that
was changed, so update it as well.

Signed-off-by: gbenhaim <[email protected]>

* Lock envtest-setup to version v0.17.2

The latest version introduced a bug that broke the CI -
kubernetes-sigs/controller-runtime#2722

In general it's better to use specific versions for the dependencies,
so their update can be tested in the CI.

Signed-off-by: gbenhaim <[email protected]>

---------

Signed-off-by: gbenhaim <[email protected]>
@sbueringer
Copy link
Member

/close

based on #2720 (comment)

Feel free to reopen if you have an idea how else we could resolve this :)

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

/close

based on #2720 (comment)

Feel free to reopen if you have an idea how else we could resolve this :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants