-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix go versions in go modules #2722
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fspaniol The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @fspaniol. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@fspaniol: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -1,6 +1,6 @@ | |||
module sigs.k8s.io/controller-runtime | |||
|
|||
go 1.22.0 | |||
go 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest. Not sure what we should do here. We won't be able to get CI green if go mod tidy changes the go mod file. I also don't want to check in a go.mod file that is updated as soon as a go command is run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responded on the issue: #2720 (comment) (just saw the comments there now)
The latest version introduced a bug that broke the CI - kubernetes-sigs/controller-runtime#2722 In general it's better to use specific versions for the dependencies, so their update can be tested in the CI. Signed-off-by: gbenhaim <[email protected]>
The latest version introduced a bug that broke the CI - kubernetes-sigs/controller-runtime#2722 In general it's better to use specific versions for the dependencies, so their update can be tested in the CI. Signed-off-by: gbenhaim <[email protected]>
The latest version introduced a bug that broke the CI - kubernetes-sigs/controller-runtime#2722 In general it's better to use specific versions for the dependencies, so their update can be tested in the CI. Signed-off-by: gbenhaim <[email protected]>
The latest version has a bug in it kubernetes-sigs/controller-runtime#2722 Signed-off-by: gbenhaim <[email protected]>
* RHTAPSRE-467: Update application-service version In order to get the changes introduced in redhat-appstudio/application-service#450, update the application service version. In the new version some of the function moved between modules, so fixing the import paths for those. In addition, when of the assertions looked for an error message that was changed, so update it as well. Signed-off-by: gbenhaim <[email protected]> * Lock envtest-setup to version v0.17.2 The latest version introduced a bug that broke the CI - kubernetes-sigs/controller-runtime#2722 In general it's better to use specific versions for the dependencies, so their update can be tested in the CI. Signed-off-by: gbenhaim <[email protected]> --------- Signed-off-by: gbenhaim <[email protected]>
/close based on #2720 (comment) Feel free to reopen if you have an idea how else we could resolve this :) |
@sbueringer: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related to #2720.
I have tried
go get
locally and I was getting the following errors before:With this change, this is solved.
To provide more context on to why this happens:
I have a local setup where I use go 1.20 but however was installing
envtest
using the latest reference.After opening this PR, as a mean of trying out, I upgraded my local Go version to 1.22, and
go get
worked with the current HEAD version. And if I execute it with this PR's state, it even changed it to1.22.0
again:Now, for whomever has older Go versions, using the current main will not work, but on the other hand, if we merge this, it will always modify the go.mod for people with newer go versions. I'll defer to the maintainers on what's the wanted approach here.
As I said, in my project I switched from
@latest
to@release-0.16
and I can move on.