Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 E2E: autoscaler e2e test #8514

Merged
merged 1 commit into from
May 5, 2023
Merged

🌱 E2E: autoscaler e2e test #8514

merged 1 commit into from
May 5, 2023

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR adds the E2E tests for autoscaler. It tests the configuration in which the autoscaler is deployment on the workload cluster. The autoscaler test works with both classy and legacy Clusters.

Thanks to @fabriziopandini for doing the initial POC on this work.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8282

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2023
@ykakarap ykakarap force-pushed the pr-e2e-autoscaler branch from debff0a to e5f3da5 Compare April 12, 2023 00:41
@ykakarap
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@ykakarap: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-scale-main-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ykakarap
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@ykakarap
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

ykakarap
ykakarap commented Apr 12, 2023
View reviewed changes
test/e2e/autoscaler_test.go Outdated Show resolved Hide resolved
@ykakarap ykakarap changed the title 🌱 E2E: autoscaler e2e test 🌱 [WIP] E2E: autoscaler e2e test Apr 12, 2023
fabriziopandini
fabriziopandini reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of nits from my side.
Also, for the sake of keeping the test matrix simple, what about having only one version of this test using CC?
@killianmuldoon @sbueringer opinions?

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved
test/e2e/data/autoscaler/autoscaler-to-workload-workload.yaml Outdated Show resolved Hide resolved
test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml Outdated Show resolved Hide resolved
test/framework/machinedeployment_helpers.go Show resolved Hide resolved
test/framework/autoscaler_helpers.go Outdated Show resolved Hide resolved
test/e2e/data/infrastructure-docker/main/cluster-template-autoscaler/md.yaml Outdated Show resolved Hide resolved
test/e2e/data/infrastructure-docker/main/cluster-template-autoscaler/md.yaml Outdated Show resolved Hide resolved
test/framework/autoscaler_helpers.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

sbueringer commented Apr 12, 2023 •
edited
Loading

just a couple of nits from my side. Also, for the sake of keeping the test matrix simple, what about having only one version of this test using CC? @killianmuldoon @sbueringer opinions?

Yes please. We are at a point where we almost have to think about how we reduce the number of tests we already have so we should be very very careful when we add new ones.
(xref: we're slowly getting close to two hours: https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api#capi-e2e-main&graph-metrics=test-duration-minutes :( )

Wondering if this also means that we should implement the test itself only for ClusterClass (to reduce maintenance effort and because we wouldn't test the legacy variant in core CAPI it's very hard to keep the legacy variant of the test working)

@sbueringer
Copy link
Member

Q: Does the test already cover all scenarios described in #8282? (I know the PR is WIP)

sbueringer
sbueringer reviewed Apr 12, 2023
View reviewed changes
test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml Outdated Show resolved Hide resolved
test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml Outdated Show resolved Hide resolved
test/e2e/autoscaler_test.go Outdated Show resolved Hide resolved
test/e2e/autoscaler_test.go Outdated Show resolved Hide resolved
test/e2e/autoscaler_test.go Outdated Show resolved Hide resolved
test/e2e/autoscaler.go Outdated Show resolved Hide resolved
test/e2e/autoscaler.go Outdated Show resolved Hide resolved
test/e2e/autoscaler.go Outdated Show resolved Hide resolved
@ykakarap ykakarap force-pushed the pr-e2e-autoscaler branch from 5c6ce87 to 8c3bdc8 Compare April 12, 2023 15:08
@elmiko
Copy link
Contributor

elmiko commented Apr 12, 2023

hey, this looks really cool. i haven't had a chance to review yet, but hopefully i can take look before kubecon.

@sbueringer
Copy link
Member

@elmiko Just a hint to avoid redundant reviews. It probably makes sense to wait for the next iteration. Addressing the findings above will result in some bigger changes to the PR.

@elmiko
Copy link
Contributor

elmiko commented Apr 13, 2023

thanks @sbueringer , i won't rush to review this one just yet.

@fabriziopandini fabriziopandini mentioned this pull request Apr 14, 2023
Closed
@ykakarap ykakarap force-pushed the pr-e2e-autoscaler branch from 8c3bdc8 to b020fb9 Compare April 15, 2023 09:23
@ykakarap ykakarap changed the title 🌱 [WIP] E2E: autoscaler e2e test 🌱 E2E: autoscaler e2e test Apr 15, 2023
sbueringer
sbueringer reviewed Apr 25, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits, overall looks good

Also checked that we cover all use cases described in #7293 (comment)

api/v1beta1/common_types.go Show resolved Hide resolved
test/e2e/data/autoscaler/autoscaler-to-workload-workload.yaml Outdated Show resolved Hide resolved
test/e2e/autoscaler_test.go Outdated Show resolved Hide resolved
test/e2e/autoscaler.go Outdated Show resolved Hide resolved
test/e2e/autoscaler.go Show resolved Hide resolved
test/framework/autoscaler_helpers.go Outdated Show resolved Hide resolved
test/framework/autoscaler_helpers.go Outdated Show resolved Hide resolved
test/framework/autoscaler_helpers.go Show resolved Hide resolved
test/framework/autoscaler_helpers.go Outdated Show resolved Hide resolved
test/framework/autoscaler_helpers.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

@elmiko If you have some time, should be ready for a round of review. I only found a few nits

@elmiko
Copy link
Contributor

elmiko commented May 2, 2023

thanks @sbueringer , will make some time this week

@sbueringer
Copy link
Member

/lgtm

pending squash + #8514 (comment)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d88a41690f6928993e984d0bb2d3025ab9e935ea

@sbueringer
Copy link
Member

/retest

fabriziopandini
fabriziopandini reviewed May 2, 2023
View reviewed changes
api/v1beta1/common_types.go Show resolved Hide resolved
test/e2e/autoscaler.go Show resolved Hide resolved
@ykakarap ykakarap force-pushed the pr-e2e-autoscaler branch from 28023f5 to 6095e3b Compare May 2, 2023 20:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@ykakarap
Copy link
Contributor Author

ykakarap commented May 2, 2023

/test pull-cluster-api-e2e-full-main

@fabriziopandini
Copy link
Member

/lgtm
approve pending one last pass from mike

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1af2731109d68014182c50511401e8320db05af2

@sbueringer
Copy link
Member

/lgtm

/retest

@sbueringer
Copy link
Member

sbueringer commented May 3, 2023 •
edited
Loading

The success rate of e2e-full on this PR is really concerning (2 failures, 1 success since yesterday), but I'm pretty sure it's not caused by anything in this PR (xref: https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=cluster-api&pr=8514)

@sbueringer
Copy link
Member

/retest

elmiko
elmiko reviewed May 4, 2023
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykakarap and @sbueringer , this is looking really nice, good work! i like how you've structured the tests. i left a couple comments, but they are suggestions not blockers for me.

test/e2e/data/autoscaler/autoscaler-to-workload-workload.yaml Show resolved Hide resolved
test/framework/autoscaler_helpers.go Outdated Show resolved Hide resolved
@ykakarap ykakarap force-pushed the pr-e2e-autoscaler branch from 6095e3b to 14d3cbb Compare May 4, 2023 18:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@ykakarap
Copy link
Contributor Author

ykakarap commented May 4, 2023

/test pull-cluster-api-e2e-full-main

1 similar comment
@ykakarap
Copy link
Contributor Author

ykakarap commented May 4, 2023

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member

Thank you very much!!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d5557e402af45d765f0d381b4bd4925888dca03

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 88face9 into kubernetes-sigs:main May 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 5, 2023
@johannesfrey
Copy link
Contributor

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added the area/e2e-testing Issues or PRs related to e2e testing label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@sbueringer sbueringer Awaiting requested review from sbueringer

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Add e2e test to cover basic autoscaler scenarios
6 participants
@ykakarap @k8s-ci-robot @sbueringer @elmiko @fabriziopandini @johannesfrey