[WIP] 🌱 Add the autoscaler e2e test #8262
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XL
|
/test pull-cluster-api-test-full-main |
|
@fabriziopandini: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-full-main |
|
@fabriziopandini: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| WaitForDeploymentsAvailable(ctx, WaitForDeploymentsAvailableInput{ | ||
| Getter: input.ClusterProxy.GetClient(), | ||
| Deployment: scalelUpDeployment, | ||
| }, intervals...) |
There was a problem hiding this comment.
could also delete and wait for the MachineDeployment to scale down fwiw https://github.com/openshift/hypershift/blob/main/test/e2e/autoscaling_test.go#L22.
|
Very nice, thanks Fabrizio! |
| # Limit cluster autoscaler to only match against resources belonging to a single Cluster API cluster | ||
| - --node-group-auto-discovery=clusterapi:namespace=${CLUSTER_NAMESPACE},clusterName=${CLUSTER_NAME} | ||
| volumeMounts: | ||
| - name: kubeconfig-management-cluster |
There was a problem hiding this comment.
It looks like this is following the pattern of installing the cluster-autoscaler deployment onto the mgmt cluster (as opposed to it being installed onto the workload cluster). Should we do a per-cluster cluster-autoscaler deployment namespace so that there is a path forward for managing multiple clusters?
| Name: fmt.Sprintf("cluster-%s-token", input.Cluster.Name), | ||
| }, | ||
| } | ||
| Eventually(func() bool { |
There was a problem hiding this comment.
slight preference for Eventually(func(g Gomega) { and then ending in .Should(Succeed(),...
This way we can assert the err and the lookups. E.g.:
g.Expect(err).NotTo(HaveOccurred())
and
_, ok := tokenSecret.Data["token"]
g.Expect(ok).To(BeTrue())This way we'll get the line that caused the failure+retry printed to stdout and debugging will be easier.
|
Thx for the reviews! Please note that this is a WIP-PR. We have a few more changes planned for this PR |
|
Created an issue to discuss the exact scope of this PR #8282 |
|
@fabriziopandini: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Probably it needs some more cleanup + migration to cc (this can be also a follow-up PR)
Fixes #8282