🌱 Move webhooks to internal

[kaitoii11]

What this PR does / why we need it:
Move webhooks to internal and create alias.go for exposing Cluster and ClusterClass

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5599

[k8s-ci-robot]

Hi @kaitoii11. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/ok-to-test

[sbueringer]

Suggested change

	clusterwebhooks "sigs.k8s.io/cluster-api/webhooks/internal/webhooks"
	"sigs.k8s.io/cluster-api/webhooks/internal/webhooks"

I think that would be better. Afaik there should be no name conflict

[sbueringer]

Two nits

[killianmuldoon]

Looking good! Could you move the files from cluster-api/webhooks/internal/webhooks/ to cluster-api/internal/webhooks ?

[sbueringer]

~

Suggested change

	return (&webhooks.Cluster{}).SetupWebhookWithManager(mgr)
	return (&webhooks.Cluster{Client: webhook.Client}).SetupWebhookWithManager(mgr)

should fix the test failures

[sbueringer]

/lgtm
assuming the test will probably be green now :)

[killianmuldoon]

/lgtm

[k8s-ci-robot]

@kaitoii11: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-apidiff-main	d096694	link	false	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[killianmuldoon]

I think the methods that are currently under /webhooks have to be deprecated rather than removed under our deprecation policy - that's why apidiff is failing.

[fabriziopandini]

I think the methods that are currently under /webhooks have to be deprecated rather than removed under our deprecation policy - that's why apidiff is failing.

This is not necessary given that webhook folder is not part of any release so far; also, FYI "moving to internal" was discussed in tht community and we should just upgrade v1.0.0 -> v1.1.0 (does not apply in this case)

[sbueringer]

I think the methods that are currently under /webhooks have to be deprecated rather than removed under our deprecation policy - that's why apidiff is failing.

This is not necessary given that webhook folder is not part of any release so far; also, FYI "moving to internal" was discussed in tht community and we should just upgrade v1.0.0 -> v1.1.0 (does not apply in this case)

Yup that's fine.

/lgtm

[killianmuldoon]

Ah - I thought they would have been part of 1.01, but bugfix only means bugfix only 😄

/lgtm

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment