separate webhooks from the api types package

[d-honeybadger]

What this PR does / why we need it:

Coupling api/ type packages with webhook by implementing webhook.Validator interface is, in hindsight, a bad design since api types are frequently imported in other projects and should therefore be as minimal as possible. The issue is discussed in kubernetes-sigs/controller-runtime#2596.

B/c of that, webhook.Validator and webhook.Defaulter interfaces are deprecated from controller-runtime and removed in v0.20

Moving webhooks to a separate package allows repos that import api/v1beta1 to upgrade controller-runtime to v0.20, and also prepares capdo for controller-runtime v0.20 upgrade. CustomValidator and CustomDefaulter are the kubebuilder-recommended way of doing webhooks now.

Special notes for your reviewer:

Release note:

Move webhooks to a separate package from api types

[k8s-ci-robot]

Welcome @d-honeybadger!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-digitalocean 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-digitalocean has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @d-honeybadger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[m3co-code]

LGTM, thanks!

[k8s-ci-robot]

@m3co-code: changing LGTM is restricted to collaborators

In response to this:

LGTM, thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cpanato]

is this something that is happening in CAPI and the other providers as well?

[cpanato]

/ok-to-test

[d-honeybadger]

is this something that is happening in CAPI and the other providers as well?

Ah that's a great question!
They moved the webhooks out of api/ a while ago kubernetes-sigs/cluster-api#5711, and put it all the way under internal/ packages.
So now that they bumped controller-runtime recently, there wasn't much refactoring necessary.
Checked a couple providers (gcp, aws) too: they still have their webhooks within api/ and implementing webhook.Validator interface, but they'll have to switch to webhook.CustomValidator soon with the controller-runtime 0.20 upgrade.

I didn't put the webhooks under internal/: was looking for a minimal refactor, and so moved then just one level out.
LMK if you'd rather replicate the structure of CAPI, where the webhooks are under /internal packages and they have an external package aliasing any methods that can't be internal.

[gottwald]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-honeybadger, gottwald, m3co-code

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gottwald]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gottwald]

/lgtm