🐛 Add v1alpha3 to scheme in order to enable conversion webhook

[Lirt]

Signed-off-by: Ondrej Vasko [email protected]

What this PR does / why we need it:

Conversion webhook is not initialized. This PR registersv1alpha3 scheme in order to initialize conversion webhook. More info in issue.

Which issue(s) this PR fixes *

Fixes #987

/hold

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @Lirt!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Lirt. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Lirt
To complete the pull request process, please assign neolit123 after the PR has been reviewed.
You can assign the PR to them by writing /assign @neolit123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Lirt]

/assign @neolit123

[k8s-ci-robot]

@Lirt: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mdbooth]

/ok-to-test

[tobiasgiese]

Seems to be a duplicate of #985

[Lirt]

I didn't notice that PR in the meantime, it was opened 1 day before mine.

Difference in code change is that the second PR includes also old CAPI schemas, which are IMO not needed here as CAPOv4 should only work with already converted ones.

[Lirt]

Test failed because of diff in zz_generated.deepcopy.go. I ran go mod tidy and make generate before I pushed so that I am sure everything is synced and there were 2 changes that are included in the commit. I don't know why there is a diff.

[neolit123]

leaving approval to the active maintainers from the OWNERS files.

[chrischdi]

/retest

I agree with @Lirt that adding the old clusterv1 is not needed.

[tobiasgiese]

Test failed because of diff in zz_generated.deepcopy.go. I ran go mod tidy and make generate before I pushed so that I am sure everything is synced and there were 2 changes that are included in the commit. I don't know why there is a diff.

@Lirt you have to run make verify to also get the boilerplate changes

[Lirt]

As the changes are the same as in PR #985 I leave it to maintainers to merge any of those.

We are already testing this change in production and so far it looks OK. Thank you for help during PR, it was good experience for me anyway.

[chrischdi]

As the changes are the same as in PR #985 I leave it to maintainers to merge any of those.

We are already testing this change in production and so far it looks OK. Thank you for help during PR, it was good experience for me anyway.

Thanks a lot for your verification and help 👍

[chrischdi]

So let's close this in favor of #985 :-)

/close

[k8s-ci-robot]

@chrischdi: Closed this PR.

In response to this:

So let's close this in favor of #985 :-)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.