🐛 Add alpha3 Resources to Scheme

[shaardie]

Upgrading from alpha3 to alpha4 is only possible, if the schemes are added.
Otherwise the controller is not able to fetch those resources.

What this PR does / why we need it:

This PR adds the old alpha3 schemes to the controller. We need it, because otherwise it is impossible to use those resources and the conversion does not work properly.

This is pretty similar to kubernetes-sigs/cluster-api#4417

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @shaardie!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @shaardie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shaardie]

Signed the CLA

[tobiasgiese]

/ok-to-test

[chrischdi]

@shaardie : do you see any need to add the clusterv1old? I don't think they are necessary for the conversion webhook of infrav1 resources.

[shaardie]

@shaardie : do you see any need to add the clusterv1old? I don't think they are necessary for the conversion webhook of infrav1 resources.

I do not know. I am not that familar with the code base and honestly did not try to add only infrav1old. But I can adapt the PR, if you want it removed.

[chrischdi]

@shaardie : as you had been first: if you adapt the change we could merge your PR imho. If you don't care that much about getting this PR merged we could also merge #988 so you would not need to adjust it.

[shaardie]

I updated the PR respectively.

[chrischdi]

/approve

[seanschneeweiss]

/approve

[shaardie]

The failed test does not look like it has someting to do with this PR.

[tobiasgiese]

@shaardie you can retrigger the test manually :)

/test pull-cluster-api-provider-openstack-e2e-test

[shaardie]

/test pull-cluster-api-provider-openstack-e2e-test

[chrischdi]

/lgtm

[chrischdi]

@jichenjc or @hidekazuna ptal :-)

[chrischdi]

By the way: that the conversion is not working is also visible in the kube-apiserver logs :-)

[jichenjc]

/approve

that the conversion is not working is also visible in the kube-apiserver logs :-)

ok, we need go through our logs to see any obvious error :)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, jichenjc, seanschneeweiss, shaardie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment