-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Document running E2E tests locally #982
✨Document running E2E tests locally #982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great info! Just noticed one small typo.
b5131dd
to
bad34a9
Compare
OPENSTACK_CLOUD_CACERT_B64=$(base64 -w /path/to/mycloud-ca.crt) | ||
``` | ||
|
||
CAPO deployed in the local kind cluster will automatically pick up a `cacert` defined in your `clouds.yaml` so you will see servers created in OpenStack without specifying `OPENSTACK_CLOUD_CACERT_B64`. However, the cacert won't be deployed to those servers, so kubelet will fail to start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I fully understand this ,the cacert is mostly used for openstack interaction defined in clouds.yaml
so why it's related to kubelet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to pass the cacert into the cluster so the cloud provider [1] can talk to OpenStack. If the cloud provider fails to come up then the Node will not become ready and the tests fail.
[1] kubelet in-tree provider, or CCM for external cloud provider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, OCCM need this cacert, thanks for the reminder
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Documents how to run E2E tests locally, including the enhancements added in #981.