✨Enhancements for running E2E tests locally #981
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/L
|
/cc @sbueringer |
Add support for clouds.yaml containing: * cacert * user_domain_name or project_domain_name
According to the comment, this step pre-populates the cache. However, the actual build step also populates the cache, so any additional work done by this step is redundant.
This allows the e2e tests to run against a cloud with multiple external networks.
mdbooth
force-pushed
the
upstream-tests
branch
from
43086b3 to
7746f28
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm thanks for the enhancement ~ |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -34,11 +34,6 @@ RUN --mount=type=cache,target=/go/pkg/mod \ | |||
| # Copy the sources | |||
| COPY ./ ./ | |||
|
|
|||
There was a problem hiding this comment.
@mdbooth Out of curiosity. Why is the caching removed? I would have assumed that podman is using the Containerfile instead.
There was a problem hiding this comment.
Yeah, podman doesn't use this file. I was looking at Dockerfile because I originally trying to create a combined file, but I couldn't make the caching work.
I removed the additional go build step because afaict it's redundant even for docker. If you notice we build again with build arguments below and the same cache. This step is likely caching artifacts which we don't use. The 'real' build will create artifacts for everything we actually use, and nothing else. This step can only result in additional work and doesn't improve cache effectiveness.
...unless I've misunderstood some semantics of buildkit? In which case we can revert this.
There was a problem hiding this comment.
I think you're probably right
What this PR does / why we need it:
This PR allows me to run the E2E tests in my environment against my local cloud. This requires enhancements in the following areas:
user_domain_name