-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update README to add coreos support and kustomize required #314
Conversation
Hi @hchenxa. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @gyliu513 |
/ok-to-test |
|
||
## Generation | ||
For convenience, a generation script which populates templates based on openstack cloud provider | ||
configuration is provided. | ||
|
||
1. Run the generation script. | ||
``` | ||
./generate-yaml.sh --provider-os [os name] | ||
./generate-yaml.sh [options] <path/to/clouds.yaml> openstack --provider-os [os name] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generate-yaml.sh [options] <path/to/clouds.yaml> <provider os: [centos,ubuntu,coreos]>
this is current grammar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems we need to provide the os cloud, refer below code:
# Check if os cloud is provided
if [[ -n "$2" ]] && [[ $2 != -* ]] && [[ $2 != --* ]]; then
CLOUD=$2
else
echo "Error: No cloud specified"
echo "You mush specify which cloud you want to use."
echo ""
print_help
exit 1
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the [os name] to [centos,ubuntu,coreos]
|
||
## Generation | ||
For convenience, a generation script which populates templates based on openstack cloud provider | ||
configuration is provided. | ||
|
||
1. Run the generation script. | ||
``` | ||
./generate-yaml.sh --provider-os [os name] | ||
./generate-yaml.sh [options] <path/to/clouds.yaml> <openstack cloud> --provider-os [centos,ubuntu,coreos] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./generate-yaml.sh clouds.yaml openstack --provideros coreos
Error: No provider OS specified
You must choose between the following operating systems: centos, ubuntu, coreos
root@kvm-017751:/go/src/sigs.k8s.io/cluster-api-provider-openstack/cmd/clusterctl/examples/openstack# ./generate-yaml.sh clouds.yaml openstack coreos/go/src/sigs.k8s.io/cluster-api-provider-openstack/cmd/clusterctl/examples/openstack#
root@kvm-017751:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, replaced the --provider-os
to <provider os>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may refer to my test result..
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gyliu513, hchenxa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Update the document to add coreos support and kustimize package required.
Release note: