Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Bump to latest CAPO v0.10 #314

Merged
merged 9 commits into from
May 20, 2024

Conversation

shiftstack-merge-bot[bot]
Copy link

No description provided.

simonklb and others added 6 commits May 14, 2024 09:07
…ot/cherry-pick-2074-to-release-0.10

[release-0.10] 🐛 Fix loadbalancer timeout panic
Don't make `remoteManagedGroups` required, since a user can use
`remoteIPPrefix` instead or even no remote parameter at all.
It's fine because Neutron will set it to an fully-open CIDR if no
remote field is provided.
Going forward I won't be able to contribute time to both CPO
and CAPO, so this commit drops me from CAPO reviewers list.
…ot/cherry-pick-2082-to-release-0.10

[release-0.10] 🌱 Drop dulek from reviewers
…ot/cherry-pick-2077-to-release-0.10

[release-0.10] 🐛 allNodesSecurityGroupRules: relax remote fields
@openshift-ci openshift-ci bot requested review from EmilienM and mdbooth May 16, 2024 12:07
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 16, 2024
Copy link

openshift-ci bot commented May 16, 2024

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

These errors were ignored up to now, which could lead controller to attempt
to recreate an existing instance under rare circumstances.
@EmilienM
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
@EmilienM
Copy link
Member

@mdbooth are you good with the bot doing this?

@EmilienM
Copy link
Member

EmilienM commented May 16, 2024

I got my answer by looking at PR history, sorry for the ping Matt 🤦‍♂️

@EmilienM
Copy link
Member

/lgtm
/approve

@EmilienM
Copy link
Member

/retitle NO-JIRA: Bump to latest CAPO v0.10

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci openshift-ci bot changed the title Merge https://github.com/kubernetes-sigs/cluster-api-provider-openstack:release-0.10 into main NO-JIRA: Bump to latest CAPO v0.10 May 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2024
@openshift-ci-robot
Copy link

@shiftstack-merge-bot[bot]: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
k8s-ci-robot and others added 2 commits May 16, 2024 06:25
…ot/cherry-pick-2086-to-release-0.10

[release-0.10] 🐛 Handle errors returned by GetInstanceStatusByName in machine controller
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@mdbooth
Copy link

mdbooth commented May 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link

openshift-ci bot commented May 20, 2024

@shiftstack-merge-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EmilienM
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 61be938 into openshift:main May 20, 2024
7 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openstack-cluster-api-controllers-container-v4.17.0-202405201608.p0.g61be938.assembly.stream.el9 for distgit openstack-cluster-api-controllers.
All builds following this will include this PR.

@pierreprinetti pierreprinetti deleted the merge-bot-main branch May 21, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants