-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: Bump to latest CAPO v0.10 #314
NO-JIRA: Bump to latest CAPO v0.10 #314
Conversation
…ot/cherry-pick-2074-to-release-0.10 [release-0.10] 🐛 Fix loadbalancer timeout panic
Don't make `remoteManagedGroups` required, since a user can use `remoteIPPrefix` instead or even no remote parameter at all. It's fine because Neutron will set it to an fully-open CIDR if no remote field is provided.
Going forward I won't be able to contribute time to both CPO and CAPO, so this commit drops me from CAPO reviewers list.
…ot/cherry-pick-2082-to-release-0.10 [release-0.10] 🌱 Drop dulek from reviewers
…ot/cherry-pick-2077-to-release-0.10 [release-0.10] 🐛 allNodesSecurityGroupRules: relax remote fields
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
These errors were ignored up to now, which could lead controller to attempt to recreate an existing instance under rare circumstances.
/ok-to-test |
@mdbooth are you good with the bot doing this? |
I got my answer by looking at PR history, sorry for the ping Matt 🤦♂️ |
/lgtm |
/retitle NO-JIRA: Bump to latest CAPO v0.10 |
@shiftstack-merge-bot[bot]: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ot/cherry-pick-2086-to-release-0.10 [release-0.10] 🐛 Handle errors returned by GetInstanceStatusByName in machine controller
d3ae65c
to
43c0ed5
Compare
/lgtm |
@shiftstack-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label acknowledge-critical-fixes-only |
[ART PR BUILD NOTIFIER] This PR has been included in build openstack-cluster-api-controllers-container-v4.17.0-202405201608.p0.g61be938.assembly.stream.el9 for distgit openstack-cluster-api-controllers. |
No description provided.