Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Document changes to Filters #1982

Merged
merged 1 commit into from
Apr 2, 2024
Merged

📖 Document changes to Filters #1982

merged 1 commit into from
Apr 2, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 28, 2024 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@k8s-ci-robot k8s-ci-robot requested review from dulek and EmilienM March 28, 2024 15:14
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 28, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 2901efe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/660bd63c6cf34f00082969d1
😎 Deploy Preview https://deploy-preview-1982--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Mar 28, 2024
Merged
Merged
Merged
Merged
Merged
@k8s-ci-robot
Copy link
Contributor

@mdbooth: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test 9cab28d link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 28, 2024
@huxcrux
Copy link
Contributor

huxcrux commented Mar 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2024
dulek
dulek suggested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typos?

docs/book/src/topics/crd-changes/v1alpha7-to-v1beta1.md Outdated
- my-tag
```

The same principal applies to all the filter types. For example:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably "principle"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bet a significant majority of native English speakers wouldn't have spotted that spelling error 👍

docs/book/src/topics/crd-changes/v1alpha7-to-v1beta1.md Outdated
id: 02e31c38-d5ba-4c57-addb-00fc71eb5b19
```

Specify a filter object by a filter parameter must now move filter parameters into the filter field:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence sounds odd to me, was the first word supposed to be "Specifying"?

@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 1, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 1, 2024 •
edited
Loading

/hold

Bah. Forgot I needed to address nits.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 1, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
MaysaMacedo
MaysaMacedo reviewed Apr 2, 2024
View reviewed changes
docs/book/src/topics/crd-changes/v1alpha7-to-v1beta1.md Outdated
@@ -14,7 +14,7 @@
- [Change to image](#change-to-image)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this section could be updated to mention the usage of ImageParam instead of ImageFilter

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is there any plan to change the serverGroupFilter to become serverGroupParam?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARGH, I missed one! 🤦

@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 2, 2024

/hold for comments and to add ServerGroupParam

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 2, 2024

Updated to reference the filter changes specificially under Images, ExternalNetwork, and Network. Additionally added ServerGroupParam, although that hasn't actually landed yet. It's in #1991

@dulek
Copy link
Contributor

dulek commented Apr 2, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@dulek
Copy link
Contributor

dulek commented Apr 2, 2024

Let's unhold once #1991 is in.

@mdbooth
Copy link
Contributor Author

mdbooth commented Apr 2, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0990569 into kubernetes-sigs:main Apr 2, 2024
8 checks passed
@mdbooth mdbooth deleted the filterparamdocs branch April 2, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaysaMacedo MaysaMacedo MaysaMacedo left review comments

@dulek dulek dulek requested changes

@EmilienM EmilienM Awaiting requested review from EmilienM

Assignees

@dulek dulek

@huxcrux huxcrux

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPO Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate API filter parameters into ID and Filter to improve discovery and validation
5 participants
@mdbooth @k8s-ci-robot @huxcrux @dulek @MaysaMacedo