⚠️ SubnetFilter to SubnetParam #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
approved
dulek
reviewed
Mar 26, 2024
| @@ -125,11 +144,25 @@ type SubnetFilter struct { | |||
| CIDR string `json:"cidr,omitempty"` | |||
| IPv6AddressMode string `json:"ipv6AddressMode,omitempty"` | |||
| IPv6RAMode string `json:"ipv6RAMode,omitempty"` | |||
| ID string `json:"id,omitempty"` | |||
|
|
|||
| FilterByNeutronTags `json:",inline"` | |||
| } | |||
There was a problem hiding this comment.
We could add comments and some validations here:
- Name and description has max length of 255 in Neutron.
- ProjectID is
uuid.uuid4().hexwhich passes K8s UUID validation. - IPVersion is an enum of 4 or 6.
- GatewayIP is IPv4 or IPv6 address.
- CIDR is CIDR.
- IPv6*Mode can be enums, but maybe here it's better to leave them unvalidated, to not require API update on new Neutron features.
There was a problem hiding this comment.
I thought about that and I deliberately didn't do it because:
- It can easily be a follow-on
- The code-churn would be different to the code churn of this PR
- This is big enough already!
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
k8s-ci-robot
added
size/XXL
4 tasks
mdbooth
force-pushed
the
subnetparam
branch
2 times, most recently
from
0e15a90 to
826eeda
Compare
3 tasks
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
5 tasks
|
Looks like a network-related flake /test pull-cluster-api-provider-openstack-e2e-full-test |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1975
TODO:
/hold