Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Move flatcar-sysext to v1alpha8 #1812

Merged

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Jan 4, 2024

This was added via v1alpha7 but the latest api is v1alpha8 and to keep
our CI consistent we will move the manifests to v1alpha8.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 173f41b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6596d7b8d78e4a0008ba316e
😎 Deploy Preview https://deploy-preview-1812--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2024
@EmilienM EmilienM changed the title Move flatcar-sysext to v1alpha8 🐛 Move flatcar-sysext to v1alpha8 Jan 4, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot requested review from dulek and lentzi90 January 4, 2024 14:05
@EmilienM
Copy link
Contributor Author

EmilienM commented Jan 4, 2024

/cc tormath1

@k8s-ci-robot k8s-ci-robot requested a review from tormath1 January 4, 2024 14:06
@EmilienM EmilienM force-pushed the flatcar-sysext-v1alpha8 branch 2 times, most recently from 2dbcdb5 to 30835b5 Compare January 4, 2024 14:19
@EmilienM EmilienM force-pushed the flatcar-sysext-v1alpha8 branch from 30835b5 to 1cb3ccf Compare January 4, 2024 14:25
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 4, 2024
@MaysaMacedo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Jan 4, 2024

We should leave the v1alpha7 templates in place and copy them to v1alpha8 with the required changes.

This was added via v1alpha7 but the latest api is v1alpha8 and to keep
our CI consistent we will move the manifests to v1alpha8.
@EmilienM EmilienM force-pushed the flatcar-sysext-v1alpha8 branch from 1cb3ccf to 173f41b Compare January 4, 2024 16:07
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 4, 2024
@MaysaMacedo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Jan 4, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3d09742 into kubernetes-sigs:main Jan 4, 2024
9 checks passed
@EmilienM EmilienM deleted the flatcar-sysext-v1alpha8 branch January 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants